[jbosstools-issues] [JBoss JIRA] (JBDS-2153) Do not embed/wrap 3rd-party bundles in our sources

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695152#comment-12695152 ] 

Nick Boldt commented on JBDS-2153:
----------------------------------

Looks like JBDS-1983 and Tycho 0.14 have removed the need clone/patch wrap 3rd party plugins and provide them wrapped w/ our features.

Just checked what happens when you take JBDS 5.0.0.CR1 and install everything from Central into it (including JRebel, which used to break the Welcome screen), and it's fine.

So... I think we're ok to "unwrap" these 3rd party inclusions. 

One caveat, however...

If we don't provide our own com.jboss.jbds.* features, then we open the floodgates for people to be able to update these features from 3rd party sites w/o our first vetting them through QE. (See "Investigate" issues JBDS-1998, JBDS-2001, JBDS-1946, JBDS-1874, JBDS-1925, etc.)

So if we want to continue to prevent users from being able to update from the version of Spring we test/support to an unsupported one (see JBDS-1925), we still need the com.jboss.jbds.* features, but they can now simply include the third party FEATURES instead of third party PLUGINS.

                
> Do not embed/wrap 3rd-party bundles in our sources
> --------------------------------------------------
>
>                 Key: JBDS-2153
>                 URL: https://issues.jboss.org/browse/JBDS-2153
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 5.0.0.Beta3
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>             Fix For: 5.0.0.CR1
>
>         Attachments: JBDS-2153-step1.png, JBDS-2153-step2.png, JBDS-2153-step3.png
>
>
> in devstudio/extras, we can see that we define some "wrapper" bundles for 3rd party deps (findbugs, pmd, spring...). This is not the most straightforward approach, and it seems like we could improve it. Here are some reasons that would have justified this implementation, and some reasons why we can improve it:
> > a) the plugin and feature have the same IU name and therefore confuse Tycho 
> How is this possible? p2 adds .feature.group to features. We should think about a 3rd-party feature that requires either this plugins or features, that we could provide in the extras site.
> > b) the plugin contributes to the welcome screen and breaks JBDS, so we override that 
> According to Max, this is no more the case.
> > c) because the license doc is incomplete so we provide a more explicit/accurate license by wrapping it w/ our own feature 
> We can use our feature and add this bundle as required, so we use their bundles and they are installed from our feature. Using required allows people to perform updates from the other sites by themselves.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira