[jbosstools-issues] [JBoss JIRA] (JBIDE-11308) server adapter adds .dodeploy before Clean/publish has finished

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-11308.
---------------------------------

    Resolution: Done


The workflow is as follows:

0) progress dialog shows up
1) WTP passes exec to me
2) publishStart is called
3) publishModule is called, once for each module
4) publishFinish is called
5) execution returns to wtp
6) wtp may take some time to finish its own stuff
7) Dialog goes away

It is during step 4) (publishFinish, AFTER all submodules are published) that we add the .dodeploy, so it is 100% expected that the monitor is still up.

During step 4), we also re-enable the deployment scanners. So it is POSSIBLE that the server may instantly recognize the .dodeploy and change it to .deploying before step 4) is done. It is *VERY VERY* likely that the server does this before step 7).

This is all 100% expected. There is no bug. Nobody would expect the dialog to go away until the publish is finished, and most people will not consider a publish to be 'finished' until the server actually recognizes the publish. But we don't wait THAT long because that would be too long really. 

The progress monitor is not just there for the copying of files. It is there for the entire publish workflow, which includes disabling and re-enabling deployment scanners, adding marker files, and then a bunch of stuff on the wtp end such as persisting deltas and other things. 

How exactly is the progress monitor lying? It doesn't go away until the publish is finished. Yes, it is no longer copying files, but the dialog is not there just for the duration of file copying. It is there for the duration of the publish workflow. 
                
> server adapter adds .dodeploy before Clean/publish has finished
> ---------------------------------------------------------------
>
>                 Key: JBIDE-11308
>                 URL: https://issues.jboss.org/browse/JBIDE-11308
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.CR1
>
>
> EXECUTE: import decent sized project, i.e. GWT project from central and follo the readme regarding tooling
> EXECUTE: after Run As have been done, right click server and press Clean...
> ASSERT: clean is done and publish goes on and then in the end .dodeploy file occurrs
> What actually seem to happen is deploymen is removed, dir added, then .dodeploy and *then* file copying occurs - causing the scanner to pickup partially deployed project.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira