[jbosstools-issues] [JBoss JIRA] (JBIDE-12993) Cleanup/create plain checkout.sh script for jbosstools repos from github

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731891#comment-12731891 ] 

Nick Boldt edited comment on JBIDE-12993 at 11/5/12 3:53 PM:
-------------------------------------------------------------

Link to previous JIRA which asked that the defaults [~maxandersen] has now implemented be changed. 

Note also that when testing your new script, it doesn't seem to like relative paths -- see last line:

{code}
$ ./checkout.sh -d . -u nickboldt esb
Cloning into ./jbosstools-esb...
remote: Counting objects: 10199, done.
remote: Compressing objects: 100% (2494/2494), done.
remote: Total 10199 (delta 4984), reused 10187 (delta 4972)
Receiving objects: 100% (10199/10199), 10.32 MiB | 1.12 MiB/s, done.
Resolving deltas: 100% (4984/4984), done.
./jbosstools-esb not found
{code}

Recommend adding a line like this after reading the commandline args (line 65):

{code}if [[ ${basedir} == "." ]]; then basedir=`pwd`; fi{code}
                
      was (Author: nickboldt):
    Link to previous JIRA which asked that the defaults [~maxandersen] has now implemented be changed. 

Note also that when testing your new script, it doesn't seem to like relative paths -- see last line:

{code}
$ ./checkout.sh -d . -u nickboldt esb
Cloning into ./jbosstools-esb...
remote: Counting objects: 10199, done.
remote: Compressing objects: 100% (2494/2494), done.
remote: Total 10199 (delta 4984), reused 10187 (delta 4972)
Receiving objects: 100% (10199/10199), 10.32 MiB | 1.12 MiB/s, done.
Resolving deltas: 100% (4984/4984), done.
./jbosstools-esb not found
{code}

Recommend adding a line like this after reading the commandline args (line 65):

if [[ ${basedir} == "." ]]; then basedir=`pwd`; fi
                  
> Cleanup/create plain checkout.sh script for jbosstools repos from github
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-12993
>                 URL: https://issues.jboss.org/browse/JBIDE-12993
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Build/Releng
>            Reporter: Max Rydahl Andersen
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.0.0.CR1
>
>
> nick have done some work on the checkout script at: https://github.com/jbosstools/jbosstools-build/blob/master/scripts/checkout.sh but it is assuming a bit too much IMO, at least more than we can currently assume.
> I suggest:
>  cleanup to checkout as if you just did clones (i.e. no removal of jbosstools- prefix)
>  allow to do it to a directory
>  don't setup branches (not something that you necessarily want to do on all repos and can be done better by custom/specific scripting)
>  fix bootstrap profiles to use full names not the names done in this script.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira