[jbosstools-issues] [JBoss JIRA] (JBIDE-12999) 2nd dialog with username and password on top of connection dialog if you use bad credentials

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732632#comment-12732632 ] 

Andre Dietisheim edited comment on JBIDE-12999 at 11/8/12 4:31 AM:
-------------------------------------------------------------------

The EclipseAuthenticator in EGit - the one we try to get in OpenShift tooling - is using the proxy credentials from the preferences. The default NetAuthenticator is not using them, it simply pops up a dialog for the user to provide those. I'm not very sure about ECF looking up proxy credentials in the prefs, I couldn't spot it looking up.
The only shortcoming I currently spot for OpenShift (since we're using the EGit EclipseAuthenticator) is that you can't be sure that noone overrides the EGit Authenticator. We make sure EGit UI is started when we pop up the connection dialog. The EGit UI bundle activator installs the EclipseAuthenticator when it starts. Given it's already started there's still room for another bundle overriding the Authenticator. The user would then get stuck again if that Authenticator does funky stuff...
                
      was (Author: adietish):
    the EclipseAuthenticator in EGit is using the proxy credentials from the preferences. The default NetAuthenticator is not using them, it simply pops up a dialog for the user to provide thos. I'm not very sure about ECF doing the same, I couldn't spot them looking up.
The only shortcoming I spot for OpenShift (since we're using the EGit EclipseAuthenticator) is that you can't be sure that noone overrides the EGit Authenticator. We simply make sure EGit UI is started when we pop up the connection dialog since EGit UI bundle activator installs the EclipseAuthenticator when it starts. Given it's already started another bundle with its very own Authenticator could override the EclipseAuthenticator. The user would then get stuck again if that Authenticator does funky stuff...
                  
> 2nd dialog with username and password on top of connection dialog if you use bad credentials
> --------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12999
>                 URL: https://issues.jboss.org/browse/JBIDE-12999
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.0.0.Beta1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>            Priority: Blocker
>             Fix For: 4.0.0.Beta2, 4.0.0.CR1
>
>         Attachments: existing-connection-auth-dialog.png, new-connection-auth-dialog.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira