[jbosstools-issues] [JBoss JIRA] (JBDS-2361) Consider removing com.jboss.jbds.* features from Extras site; keep only 3rd party content in Central site

Nick Boldt (JIRA) jira-events at lists.jboss.org
Thu Nov 15 13:34:22 EST 2012 

    [ https://issues.jboss.org/browse/JBDS-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734684#comment-12734684 ] 

Nick Boldt edited comment on JBDS-2361 at 11/15/12 1:33 PM:
------------------------------------------------------------

*Not in Central / Dead Code*
{quote}
- com.jboss.jbds.adt.feature
- com.jboss.jbds.findbugs.feature
- com.jboss.jbds.jslint.feature
- com.jboss.jbds.pmd.feature
{quote}

*Not in Central... should it be?*
{quote}
- RSF com.jboss.jbds.m2e.extras.feature (org.jboss.tools.maven.gwt.feature + org.jboss.tools.maven.jbosspackaging.feature)
{quote}

Central includes org.jboss.tools.maven.gwt.feature, but not org.jboss.tools.maven.jbosspackaging.feature. org.jboss.tools.maven.jbosspackaging.feature is currently in JBT Core and JBDS Extras sites.

*{color:red}Should a new connector be added to JBT/JBDS Central for org.jboss.tools.maven.jbosspackaging.feature?{color}*

*ISF: In Central, INCLUDES 3rd party Selected feature(s):  feature wrapper only*
{quote}
+ ISF com.jboss.jbds.eclipsecs.feature
+ ISF com.jboss.jbds.git.mylyn.feature
+ ISF com.jboss.jbds.gwt.designer.feature
+ ISF com.jboss.jbds.gwt.feature
+ ISF com.jboss.jbds.springide.feature
+ ISF com.jboss.jbds.subclipse.feature
{quote}

*ICF: In Central, INCLUDES 3rd party Certified feature(s):  feature wrapper only*
{quote}
+ ICF com.jboss.jbds.testng.feature
{quote}

*RSF: In Central, REQUIRES 3rd party Selected feature(s):  feature wrapper only*
{quote}
+ RSF com.jboss.jbds.subclipse.mylyn.feature
{quote}

So, we can probably drop *ALL* these in favour of just including the included/required features in JBDS Central... 

*{color:red}EXCEPT the jbds.mylyn feature, which is a bit more complicated{color}*:

*RSP: In Central, REQUIRES 3rd party Selected plugins(s) & features, includes org.jboss.tools.common.mylyn plugin*
{quote}
+ ISP com.jboss.jbds.mylyn.feature
{quote}


{code:title=https://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.mylyn.feature/feature.xml}
	<!-- JBDS-2098 add defaults for issues.jboss.org and bugzilla.redhat.com -->
	<plugin id="org.jboss.tools.common.mylyn" download-size="0" install-size="0" version="0.0.0" />

	<requires>
		<import feature="org.eclipse.mylyn_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.ide_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.commons" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.context_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.bugzilla_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.java_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.pde_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.team_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.cvs" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.versions" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.wikitext_feature" version="0.0.0" match="greaterOrEqual" />

		<plugin id="com.atlassian.connector.eclipse.bamboo.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.bamboo.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.crucible.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.crucible.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.fisheye.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.fisheye.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.subclipse.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.subclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.eclipse.mylyn.tasks.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.mylyn.tasks.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.mylyn.tasks.bugs" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="com.atlassian.connector.commons" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.branding.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.commons.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.commons.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.cvs.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.cvs.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.directclickthrough.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.help" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.jira.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.jira.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.monitor.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.monitor.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<!-- JBDS-1682 dependent 3rd party plugins needed to install Atlassian JIRA support -->
		<plugin id="com.thoughtworks.xstream" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.eclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.runtime" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.resources" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.ide" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.workbench.texteditor" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.jface.text" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.osgi" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.filesystem" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.forms" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.editors" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.team.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.team.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.jface" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.compare" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.apache.axis" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.logging" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.io" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.httpclient" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.lang" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.codec" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.jdom_jaxen" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.mortbay.jetty.server" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.mortbay.jetty.util" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.jasper" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.joda.time" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="javax.servlet" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.servlet.jsp" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.xml.rpc" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.el" version="0.0.0" match="greaterOrEqual" unpack="false" />
	</requires>
{code}

{code:title=https://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.mylyn.feature/p2.inf}
instructions.configure=\
 org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//download.eclipse.org/mylyn/releases/3.6);\
 org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//download.eclipse.org/mylyn/releases/3.6);
{code}

                
      was (Author: nickboldt):
    *Not in Central / Dead Code*
{quote}
- com.jboss.jbds.adt.feature
- com.jboss.jbds.findbugs.feature
- com.jboss.jbds.jslint.feature
- com.jboss.jbds.pmd.feature
{quote}

*Not in Central... should it be?*
{quote}
- RSF com.jboss.jbds.m2e.extras.feature (org.jboss.tools.maven.gwt.feature + org.jboss.tools.maven.jbosspackaging.feature)
{quote}

Central includes org.jboss.tools.maven.gwt.feature, but not org.jboss.tools.maven.jbosspackaging.feature. org.jboss.tools.maven.jbosspackaging.feature is currently in JBT Core and JBDS Extras sites.

Should a new connector be added to JBT/JBDS Central for org.jboss.tools.maven.jbosspackaging.feature ?


*ISF: In Central, INCLUDES 3rd party Selected feature(s):  feature wrapper only*
{quote}
+ ISF com.jboss.jbds.eclipsecs.feature
+ ISF com.jboss.jbds.git.mylyn.feature
+ ISF com.jboss.jbds.gwt.designer.feature
+ ISF com.jboss.jbds.gwt.feature
+ ISF com.jboss.jbds.springide.feature
+ ISF com.jboss.jbds.subclipse.feature
{quote}

*ICF: In Central, INCLUDES 3rd party Certified feature(s):  feature wrapper only*
{quote}
+ ICF com.jboss.jbds.testng.feature
{quote}

*RSF: In Central, REQUIRES 3rd party Selected feature(s):  feature wrapper only*
{quote}
+ RSF com.jboss.jbds.subclipse.mylyn.feature
{quote}

So, we can probably drop *ALL* these in favour of just including the included/required features in JBDS Central... 

*{color:red}EXCEPT the jbds.mylyn feature, which is a bit more complicated{color}*:

*RSP: In Central, REQUIRES 3rd party Selected plugins(s) & features, includes org.jboss.tools.common.mylyn plugin*
{quote}
+ ISP com.jboss.jbds.mylyn.feature
{quote}


{code:title=https://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.mylyn.feature/feature.xml}
	<!-- JBDS-2098 add defaults for issues.jboss.org and bugzilla.redhat.com -->
	<plugin id="org.jboss.tools.common.mylyn" download-size="0" install-size="0" version="0.0.0" />

	<requires>
		<import feature="org.eclipse.mylyn_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.ide_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.commons" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.context_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.bugzilla_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.java_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.pde_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.team_feature" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.cvs" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.versions" version="0.0.0" match="greaterOrEqual" />
		<import feature="org.eclipse.mylyn.wikitext_feature" version="0.0.0" match="greaterOrEqual" />

		<plugin id="com.atlassian.connector.eclipse.bamboo.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.bamboo.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.crucible.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.crucible.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.fisheye.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.fisheye.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.subclipse.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.subclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.eclipse.mylyn.tasks.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.mylyn.tasks.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.mylyn.tasks.bugs" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="com.atlassian.connector.commons" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.branding.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.commons.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.commons.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.cvs.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.cvs.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.directclickthrough.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.help" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.jira.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.jira.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.monitor.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.monitor.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="com.atlassian.connector.eclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<!-- JBDS-1682 dependent 3rd party plugins needed to install Atlassian JIRA support -->
		<plugin id="com.thoughtworks.xstream" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.eclipse.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.runtime" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.resources" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.ide" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.workbench.texteditor" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.jface.text" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.osgi" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.core.filesystem" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.forms" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.ui.editors" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.team.core" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.team.ui" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.jface" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.eclipse.compare" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.apache.axis" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.logging" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.io" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.httpclient" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.lang" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.commons.codec" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="org.jdom_jaxen" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.mortbay.jetty.server" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.mortbay.jetty.util" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.apache.jasper" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="org.joda.time" version="0.0.0" match="greaterOrEqual" unpack="false" />

		<plugin id="javax.servlet" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.servlet.jsp" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.xml.rpc" version="0.0.0" match="greaterOrEqual" unpack="false" />
		<plugin id="javax.el" version="0.0.0" match="greaterOrEqual" unpack="false" />
	</requires>
{code}

{code:title=https://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.mylyn.feature/p2.inf}
instructions.configure=\
 org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//download.eclipse.org/mylyn/releases/3.6);\
 org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//download.eclipse.org/mylyn/releases/3.6);
{code}

                  
> Consider removing com.jboss.jbds.* features from Extras site; keep only 3rd party content in Central site
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBDS-2361
>                 URL: https://issues.jboss.org/browse/JBDS-2361
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Build, central, updatesite
>    Affects Versions: 6.0.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Max Rydahl Andersen
>             Fix For: 6.0.0.CR1
>
>
> As per https://issues.jboss.org/browse/JBDS-2284?focusedCommentId=12726296&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12726296 ... 
> we can now look at eliminating the remaining JBDS Extras features, and keeping the contents therein only in Central:
> {quote}
> * TestNG
> * SpringIDE
> * Mylyn
> * Git.Mylyn
> * Eclipse-CS
> * GWT
> * GWT.Designer
> * Subclipse
> * Subclipse.Mylyn
> * com.jboss.jbds.m2e.extras (JBoss Tools Maven Integration plugins for GWT and JBoss Packaging)
> {quote}
> Assigned to Max for comment then back to me to do the work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the jbosstools-issues mailing list