[jbosstools-issues] [JBoss JIRA] (JBIDE-13125) discovery plugin cleanup

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736076#comment-12736076 ] 

Max Rydahl Andersen commented on JBIDE-13125:
---------------------------------------------

Here are my "Raw" notes:
Discovery review:

General comments - should stop using IU as name of new connectors.

org.eclipse.jst.server_core.feature - What is this used for ? These are part of JEE by default, why do we need them ?

com.android.ide.eclipse.adt - looks fine feature wise, excludes ndk which requires CDT. makes sense.

com.google.gdt.eclipse.designer.editor.feature - ok. Main concern here is what will happen when these things move to window builder at eclipse ? (if ever). License - EPL, Other - what is other?

com.google.gpe.gwt - ok. overlaps with editor feature in some of its plugins. Should be fine since p2 would detect they are already installed.
EPL, Other - what is other?

com.springframework.ide.eclipse.feature - seems ok.	
This says "Free" on top of EPL and Other…. ?

com.atlassian.connector.eclipse - no IU listed. Should not be using id as the IU anymore.

org.eclipse.egit - looks fine, but wondering if it is this still relevant to include on Juno ? doesn't Juno come with it these days?

org.eclipse.egit.mylyn - this says eclipse egis and github but also adds bugzilla, pre, team, github and other things ….
    shouldn't this just be egit+github+mylyn ? and not bugzilla also ?

org.tigris.subversion.subclipse.mylyn - this installs both mylun and subclipse -  for egit these two are separate…why not for svn too ?

net.sf.eclipsecs - looks okey, but what is com.github.sevntu.checkstyle.checks.feature?
  Looking at http://eclipse-cs.sourceforge.net/ these looks to be like "experimental"/breeding ground for extra checks.
  Do we think these are worth/stable enough to include ?

edu.umd.cs.findbugs.plugin.eclipse - looks fine.

"org.jboss.tools.common.mylyn.feature - ok - but optimally these should be a JBoss Jira and Red Hat Bugzilla entry; but I guess as long as they are  marked as optional in *one* feature there is not a way to do this?

net.sourceforge.pmd.eclipse -  seems fine.
  Says  "Free, PMD License" ..why the extra word license  here ? 

org.testng.eclipse - seems recent, 6.7 vs 6.8 ? anything we need from that ?

org.zeroturnaround.eclipse.feature - this seems to be what needs the server_core.feature - why not just have these listed as <iu's> in the new world where there is just one site ?

All the individual Maven features - are they just here because of that is what project examples uses ? 
   Couldn't the maven integration for eclipse/jdt-apt/mvaen profile management ui and possibly m2e-wtp just be one "org.jboss.tools.central.maven" connector ID ? Leaving the extensions like hibernate, gwt, etc. as the ones to install on top ?
 (need to be checked which connector id's the examples uses)
                
> discovery plugin cleanup
> ------------------------
>
>                 Key: JBIDE-13125
>                 URL: https://issues.jboss.org/browse/JBIDE-13125
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>            Reporter: Max Rydahl Andersen
>
> Because of JBDS-2361 and JBIDE-12556 I spent some time reviewing the discovery plugin.xml and found a few items.
> I'll put my raw list in the comments, but here are the highlights:
> - new connector ID's should not use the same name as the feature they refer to; this is so project examples can refer to them as "the maven plugins" instead of "org.eclipse.m2e" when it might be a different name.
> - The word "Free" is added to some entries but not to others.
> - egit and egit.mylyn are two seperate things (good), subversion/subclipse.mylyn is one big one (bad). 
> - eclipsecs includes experiemental com.github.sevntucheckstyle feature - do we need/want that ?
> - common.mylyn.feature - can that be split into bugzilla and jira one ?
> - jrebel requires server_core feature but why aren't they just listed in there and remove the need for seperate core/server feature ?
> - Maven connectors seem to be too fine-grained, why do we have m2e,m2e-jdt and m2e-wtp as separate connectors ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira