[jbosstools-issues] [JBoss JIRA] (JBIDE-12783) Missing QuickFix context menu within Source pane of VPE for JSF project

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727232#comment-12727232 ] 

Victor Rubezhny commented on JBIDE-12783:
-----------------------------------------

Thanks to Slava, I've made a patch that fixes the issue. 

IMHO, the reason of the issue is either a bug in eclipse's pop-up menu extenders that create menu item widgets by a repeatedly called MenuManager.update(boolean, boolean) method or in MenuManager.update(bolean, boolean) method itself which cannot merge existing (already created) menu items into resulting context menu.
Probably we have some extra menu items defined which cause this merge issue to happen with the Manager.update(boolean, boolean) method.

I asked platform-ui-dev at eclipse.org regarding the issue, but was suggested to create an issue in bugzilla as well as to provide an example on how to reproduce. I can't quickly get a working example of a multy page editor with the same non-working menu quickly (without using VPE's as a source editor and pushing too much code to bugzilla as well)

Based on a suggestion that we can prevent an incorrect menu items merging by a cleaning the menu items before a final call to MenuManager.upate(boolean, boolean) method, I created a workaround patch that fixes the issue.
                
> Missing QuickFix context menu within Source pane of VPE for JSF project
> -----------------------------------------------------------------------
>
>                 Key: JBIDE-12783
>                 URL: https://issues.jboss.org/browse/JBIDE-12783
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml source editing
>    Affects Versions: 4.0.0.Alpha2
>         Environment: Linux 64bit, Eclipse SDK 4.2.1, JBT 4.0.0.Alpha2-v20121002-1149-B19
>            Reporter: Vlado Pakan
>            Assignee: Victor Rubezhny
>            Priority: Critical
>             Fix For: 4.0.0.CR1
>
>         Attachments: disabledquickfixmenuproblemsview.png, noquickfixmenuvpe.png
>
>
> 1. Create JSF project
> 2. Open inputUserName.jsp
> 3. Change EL "#{user.name}" to "#{user.sname}"
> 4. Warning marker is displayed on side of VPE and warning appeared in Problems view
> 5. Right click on changed EL
> ERROR: There is no QuickFix context menu
> !noquickfixmenuvpe.png!
> ERROR: QuickFix menu in Problems view is disabled
> !disabledquickfixmenuproblemsview.png!
> Workaround is to press Ctrl+1 in VPE editor
> It's probably introduced by new Eclipse SDK 4.2.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira