[jbosstools-issues] [JBoss JIRA] (JBIDE-12898) default server logic seems a bit broken in login dialog

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-12898:
-------------------------------------

    Description: 
I edited ~/.openshift/express.conf and set libra_server to 192.168.1.40 (bogus ip)

New openshift conneciton ui then shows a red box next to it with a tooltip stating:

"You have to provide a valid server to connect to"  (see screenshot)

That message does not really say what is wrong, i.e. what is causing a red error on a server that is the default server.

If I then go and uncheck "use default server" and put in "wonkaserver" (bogus name) the error goes away.

If I then press Ok it comes back saying my credentials are not valid - my guess would be its actually a connection error that is happening not an auth error.

If i change it to openshift.redhat.com things work again (I can validate)

And finally if I enable "use default server" again it actually stores the server I typed in instead of using the default server.

In short - default server checkbox is not listened to, it always take from the content of the checkbox (apparently) and there are some error checks that is not done/needed consistently.

to sum up, we have the following issues:

1) server in form of IP-address in express.conf is considered as invalid
2) if you provide a bogus server, validation reports invalid credentials instead of "unable to connect" 
3) Checking "use default" does not lead to the default server being used. Wizard is still using the server that was entered into the combo
4) the wizard is not using the last used connection, but is always suggesting <New connection> (launch credentials validation by launch application creation/import wizard from central or new wizards)

  was:
I edited ~/.openshift/express.conf and set libra_server to 192.168.1.40 (bogus ip)

New openshift conneciton ui then shows a red box next to it with a tooltip stating:

"You have to provide a valid server to connect to"  (see screenshot)

That message does not really say what is wrong, i.e. what is causing a red error on a server that is the default server.

If I then go and uncheck "use default server" and put in "wonkaserver" (bogus name) the error goes away.

If I then press Ok it comes back saying my credentials are not valid - my guess would be its actually a connection error that is happening not an auth error.

If i change it to openshift.redhat.com things work again (I can validate)

And finally if I enable "use default server" again it actually stores the server I typed in instead of using the default server.

In short - default server checkbox is not listened to, it always take from the content of the checkbox (apparently) and there are some error checks that is not done/needed consistently.

to sum up, we have the following issues:

1) server in form of IP-address in express.conf is considered as invalid
2) if you provide a bogus server, validation reports invalid credentials instead of "unable to connect" 
3) Checking "use default" does not lead to the default server being used. Wizard is still using the server that was entered into the combo
4) the wizard is not using the last used connection, but is always suggesting <New connection>


    
> default server logic seems a bit broken in login dialog
> -------------------------------------------------------
>
>                 Key: JBIDE-12898
>                 URL: https://issues.jboss.org/browse/JBIDE-12898
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Andre Dietisheim
>         Attachments: invalidserver.png
>
>
> I edited ~/.openshift/express.conf and set libra_server to 192.168.1.40 (bogus ip)
> New openshift conneciton ui then shows a red box next to it with a tooltip stating:
> "You have to provide a valid server to connect to"  (see screenshot)
> That message does not really say what is wrong, i.e. what is causing a red error on a server that is the default server.
> If I then go and uncheck "use default server" and put in "wonkaserver" (bogus name) the error goes away.
> If I then press Ok it comes back saying my credentials are not valid - my guess would be its actually a connection error that is happening not an auth error.
> If i change it to openshift.redhat.com things work again (I can validate)
> And finally if I enable "use default server" again it actually stores the server I typed in instead of using the default server.
> In short - default server checkbox is not listened to, it always take from the content of the checkbox (apparently) and there are some error checks that is not done/needed consistently.
> to sum up, we have the following issues:
> 1) server in form of IP-address in express.conf is considered as invalid
> 2) if you provide a bogus server, validation reports invalid credentials instead of "unable to connect" 
> 3) Checking "use default" does not lead to the default server being used. Wizard is still using the server that was entered into the combo
> 4) the wizard is not using the last used connection, but is always suggesting <New connection> (launch credentials validation by launch application creation/import wizard from central or new wizards)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira