[jbosstools-issues] [JBoss JIRA] (JBIDE-12902) Project runtime pref page modifies original model without call to performOK or performApply

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker updated JBIDE-12902:
--------------------------------

    Attachment: JBIDE-12902a.patch


tiny change, moving the isDirty set flag to a position after a .equals
                
> Project runtime pref page modifies original model without call to performOK or performApply
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12902
>                 URL: https://issues.jboss.org/browse/JBIDE-12902
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime detection
>    Affects Versions: 4.0.0.Beta1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.0.0.CR1
>
>         Attachments: JBIDE-12902.patch, JBIDE-12902a.patch
>
>
> Add, edit, and remove, all edit the core model of runtime paths in this preference page. Also, the preference page is often closed and re-opened when this doesn't need to happen. 
> Possible fixes are 
> 1) to ensure NO ONE saves a model until performOK or performApply is called, 
> 2) keep track of if the page is dirty or not
> 3) show a dialog when clicking 'link' on a dirty page asking to save and re-open the page

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira