[jbosstools-issues] [JBoss JIRA] (JBIDE-12583) Unify two download-runtime models in o.j.t.runtime.as.handler plugin

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719636#comment-12719636 ] 

Nick Boldt commented on JBIDE-12583:
------------------------------------

runtime-soa component can no longer build after these refactorings. Need assistance here. Rob?

{code}
cd ~/trunk/runtime-soa
mvn clean install -Pdefault,jbosstools-nightly-staging-composite,jbosstools-nightly-staging-composite-soa-tooling

...

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.15.0:compile (default-compile) on project org.jboss.tools.runtime.soa.test: Compilation failure: Compilation failure:
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[89,0]
[ERROR] runtimePaths.add(runtimePath);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Cannot invoke add(RuntimePath) on the array type RuntimePath[]
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[91,0]
[ERROR] RuntimeUIActivator.getDefault().saveRuntimePaths();
[ERROR] ^^^^^^^^^^^^^^^^
[ERROR] The method saveRuntimePaths() is undefined for the type RuntimeUIActivator
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[104,0]
[ERROR] Set<RuntimePath> runtimePaths = RuntimeUIActivator.getDefault()
[ERROR] .getRuntimePaths();
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Type mismatch: cannot convert from RuntimePath[] to Set<RuntimePath>
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[110,0]
[ERROR] runtimePath.getRuntimeDefinitions().clear();
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Cannot invoke clear() on the array type RuntimeDefinition[]
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[114,0]
[ERROR] runtimePath.getRuntimeDefinitions().addAll(serverDefinitions);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Cannot invoke addAll(List<RuntimeDefinition>) on the array type RuntimeDefinition[]
[ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/runtime-soa/tests/org.jboss.tools.runtime.soa.test/src/org/jboss/tools/runtime/test/RuntimeDetectionTest.java:[138,0]
[ERROR] "runtimePaths.size()\nExpected: 6\nWas: " + runtimePaths.size(),
[ERROR] ^^^^^^^^^^^^^^^^^^^
[ERROR] Cannot invoke size() on the array type RuntimePath[]
[ERROR] 6 problems (6 errors)
[ERROR] -> [Help 1]
[ERROR] 
{code}
                
> Unify two download-runtime models in o.j.t.runtime.as.handler plugin
> --------------------------------------------------------------------
>
>                 Key: JBIDE-12583
>                 URL: https://issues.jboss.org/browse/JBIDE-12583
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS/Servers, runtime detection
>    Affects Versions: 4.0.0.Alpha2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.0.0.Alpha2
>
>         Attachments: JBIDE-12583.astools.png, JBIDE-12583.runtime.png
>
>
> ASTools has an integration plugin for astools vs runtime. With runtime now living at the bottom of the stack, this plugin may no longer be useful. 
> The runtime wizard dialog cannot load any runtime.ui dialogs because there is no dependency between as.ui and runtime.ui. To add a dependency here would basically make o.j.t.runtime.as.handler to be useless. All the code there could easily be pushed into astools' other plugins. 
> This isn't a huge priority, but it is a little silly to have two models doing exactly the same thing. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira