[jbosstools-issues] [JBoss JIRA] (JBIDE-12635) -DskipPrivateRequirements=false in seam tests (and maybe others?) cause tests to always run even when -Dmaven.test.skip=true

[Mickael Istria (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mickael Istria resolved JBIDE-12635.
------------------------------------

    Resolution: Done


I introduced a new property (skipTestsWithPrivateRequirements) using default value and a profile to simulate a "OR". Tests depending on private requirements use this property, which is then equivalent to ${skipPrivateRequirements} || ${maven.test.skip}
                
> -DskipPrivateRequirements=false in seam tests (and maybe others?) cause tests to always run even when -Dmaven.test.skip=true
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12635
>                 URL: https://issues.jboss.org/browse/JBIDE-12635
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng, Seam 2, testing
>    Affects Versions: 4.0.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>             Fix For: 4.0.0.Alpha2
>
>
> Looking over the log of https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Trunk/job/jbosstools-4.0_trunk.component--seam/ I see that these tests are run...
> {code}
> org.jboss.tools.seam121EAP.core.test
> org.jboss.tools.seam121EAP.ui.test
> org.jboss.tools.seamfp.core.test
> org.jboss.tools.seamfp.ui.test
> {code}
> ... despite the fact that  -Dmaven.test.skip=true is set:
> {code}
> [sources] $ /qa/tools/opt/apache-maven-3.0.4/bin/mvn -f /mnt/hudson_workspace/workspace/jbosstools-4.0_trunk.component--seam/sources/pom.xml "-DMAVEN_FLAGS=-B -U -fae -e -P hudson,jbosstools-nightly-staging-composite,local.site,local.composite" -Ddownload.cache.directory=/home/hudson/static_build_env/jbds/download-cache -Dmaven.repo.local=/mnt/hudson_workspace/workspace/jbosstools-4.0_trunk.component--seam/.repository clean install -B -U -fae -e -P hudson,jbosstools-nightly-staging-composite,local.site,local.composite -DJOB_NAME=jbosstools-4.0_trunk.component--seam -DBUILD_ID=2012-09-18_05-22-15 -DBUILD_NUMBER=39 -Dmaven.test.skip=true -DskipPrivateRequirements=false
> {code}
> Seems like the problem is in the tests' pom.xml files:
> {code:title=http://anonsvn.jboss.org/repos/jbosstools/trunk/seam/tests/org.jboss.tools.seam121EAP.ui.test/pom.xml lines 55-70}
> 			<plugin>
> 				<groupId>org.eclipse.tycho</groupId>
> 				<artifactId>tycho-surefire-plugin</artifactId>
> 				<configuration>
> 					<skip>${skipPrivateRequirements}</skip><!-- should this be here? -->
> 					<explodedBundles>
> 						<bundle>org.jboss.tools.seam.ui.test</bundle>
> 						<bundle>org.jboss.tools.seam.core.test</bundle>
> 						<bundle>org.jboss.tools.seam.core</bundle>
> 					</explodedBundles>
>                                    ...
> 			</plugin>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira