[jbosstools-issues] [JBoss JIRA] (JBIDE-12583) Unify two download-runtime models in o.j.t.runtime.as.handler plugin

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720471#comment-12720471 ] 

Rob Stryker commented on JBIDE-12583:
-------------------------------------

The test suite in runtime-soa is 100% an exact clone of the test that was in runtime before, and was moved to seam now. pre-refactor, the two were identical. Even the package names inside the plugin are exactly the same. In my opinion, this is basically an exact clone of what became org.jboss.tools.runtime.seam.detector.test.  

I'm committing a change that simply copies over the test in that seam plugin into this one (adjusting package names only). I see no reason why the test should fail after this, but I *am* havign problems running the test locally. My attempt to build runtime-soa comes up with the following:


[INFO] Cannot complete the request.  Generating details.
[INFO] Cannot complete the request.  Generating details.
[INFO] {osgi.ws=cocoa, osgi.os=macosx, osgi.arch=x86, org.eclipse.update.install.features=true}
[ERROR] Cannot resolve project dependencies:
[ERROR]   Software being installed: org.jboss.tools.runtime.esb.detector 1.4.0.qualifier
[ERROR]   Missing requirement: org.jboss.tools.runtime.esb.detector 1.4.0.qualifier requires 'bundle org.jboss.tools.esb.project.core 0.0.0' but it could not be found
[ERROR] 


This is running the following command: [rob at benny runtime-soa]  mvn verify -P unified.target -Pjbosstools-staging-aggregate 
                
> Unify two download-runtime models in o.j.t.runtime.as.handler plugin
> --------------------------------------------------------------------
>
>                 Key: JBIDE-12583
>                 URL: https://issues.jboss.org/browse/JBIDE-12583
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS/Servers, runtime detection
>    Affects Versions: 4.0.0.Alpha2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.0.0.Alpha2
>
>         Attachments: JBIDE-12583.astools.png, JBIDE-12583.runtime.png
>
>
> ASTools has an integration plugin for astools vs runtime. With runtime now living at the bottom of the stack, this plugin may no longer be useful. 
> The runtime wizard dialog cannot load any runtime.ui dialogs because there is no dependency between as.ui and runtime.ui. To add a dependency here would basically make o.j.t.runtime.as.handler to be useless. All the code there could easily be pushed into astools' other plugins. 
> This isn't a huge priority, but it is a little silly to have two models doing exactly the same thing. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira