[jbosstools-issues] [JBoss JIRA] (JBIDE-12754) FacesConfigValidator wrongly checks for NavigationHandler implementation

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722626#comment-12722626 ] 

Viacheslav Kabanovich commented on JBIDE-12754:
-----------------------------------------------

Test use-case:
EXECUTE: Create class test.MyNavigationHandler that extends javax.faces.application.NavigationHandler.
EXECUTE: Add to faces-config.xml
{code}
<application>
  <navigation-handler>test.MyNavigationHandler</navigation-handler>
</application>
{code}
ASSERT: There is no error marker on 'test.MyNavigationHandler'.
FAILURE: There is error marker on 'test.MyNavigationHandler' "...does not implement interface javax.faces.application.NavigationHandler". 
EXECUTE: Remove extends statement from test.MyNavigationHandler.
ASSERT: There is error marker on 'test.MyNavigationHandler': "...does not extend javax.faces.application.NavigationHandler".
                
> FacesConfigValidator wrongly checks for NavigationHandler implementation 
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-12754
>                 URL: https://issues.jboss.org/browse/JBIDE-12754
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 3.3.1
>            Reporter: Ozan Ayyüce
>            Assignee: Alexey Kazakov
>            Priority: Minor
>             Fix For: 4.0.0.Beta1
>
>   Original Estimate: 10 minutes
>  Remaining Estimate: 10 minutes
>
> When validating faces-config, a custom navigation-handler class gets reported as "does not implement interface javax.faces.application.NavigationHandler". NavigationHandler is not an interface but an abstract class.
> FacesConfigValidator, when creating check for navigation-handler in createChecks(), should call new JSFCheckClass with 'javax.faces.application.NavigationHandler' in extends-type parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira