[jbosstools-issues] [JBoss JIRA] (JBIDE-13967) Need to add org.eclipse.jetty.rewrite to target platform

Yahor Radtsevich (JIRA) jira-events at lists.jboss.org
Thu Apr 11 05:52:55 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-13967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766410#comment-12766410 ] 

Yahor Radtsevich commented on JBIDE-13967:
------------------------------------------

[~maxandersen]:
bq. Are we doing some custom rewrite rules or how ?
In short, yes.

Our modification of Ripple works in the following way (original Ripple does the same, but with iframes instead of pop-ups):
Let's say, we want to use Ripple for http://localhost:4400/accelerometer.html, then:
- we point our SWT browser to http://localhost:4400/accelerometer.html?enableripple=true
- the Jetty server responds with {{/ripple/assets/index.html}} in the response body (it is the main page of Ripple, which contains accelerometer, geolocation, etc.)
- this page contains a script, which removes {{'?enableripple=true'}} from its own URL parameters and opens http://localhost:4400/accelerometer.html in a pop-up
- our code intercept this pop-up opening and set BrowserSim to be this pop-up window

Given above, Ripple requires the following rewrite rule to be specified:
_If a request contains parameter {{enableripple=true}}, then {{/ripple/assets/index.html}} must be returned in the response._

Also see [ServerCreator.java:87|https://github.com/yradtsevich/jbosstools-vpe/blob/57e8f5520b9d2bbe06a3666ac04c30f98740738f/plugins/org.jboss.tools.vpe.cordovasim/src/org/jboss/tools/vpe/cordovasim/ServerCreator.java#L87].
                
> Need to add org.eclipse.jetty.rewrite to target platform
> --------------------------------------------------------
>
>                 Key: JBIDE-13967
>                 URL: https://issues.jboss.org/browse/JBIDE-13967
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: target-platform, Visual Page Editor core
>            Reporter: Ilya Buziuk
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.1.0.Beta1
>
>
> *Reason*: Required by cordovasim (ripple) plugin described in JBIDE-13552
> *License and owner*: dual licensed Apache License 2.0 and EPL 1.0.
> *Original repository*: http://download.eclipse.org/jetty/updates/jetty-bundles-8.x/
> *JBoss Mirrored repository*:  http://downloads.jboss.org/jbosstools/updates/requirements/jetty/8.1.9.v20130131/
> *Source*: original repository contains source bundles
> *Affected projects*:  org.jboss.tools.vpe.cordovasim; org.jboss.tools.vpe.cordovasim.eclipse and possibly also livereload which also uses jetty.
> *Required in devstudio*: yes
> *Type of dependency*: distribution
> *List of bundles added/removed*: org.eclipse.jetty.rewrite

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list