[jbosstools-issues] [JBoss JIRA] (JBIDE-13848) Issue caused by changing editor ID for ClassFileEditor in Juno

Max Rydahl Andersen (JIRA) jira-events at lists.jboss.org
Fri Apr 12 09:07:56 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766757#comment-12766757 ] 

Max Rydahl Andersen commented on JBIDE-13848:
---------------------------------------------

It's a bit hard to track what/how this feature work but using hardcoded paths sounds like the *most* wrong thing to do.

A) the plugin requires m2e, and it requires the sources to be downloaded dynamically to what is defined as M2_REPO.

B) if you do not have m2e installed you do not have M2_REPO but then the path will also not exist but the source lookup plugin wont work so its broken anyway

If used M2_REPO instead of a hardcoded path *then* you can as a user at least define M2_REPO and things will work assuming you got sources downloaded.


That said - Snjezana, this new feature has so many funky sideeffects and behaviors that both Fred and I are getting lost in this - could you *document* what this feature does, i.e. what parts are hardcoded, what part is changing users configuration files (i.e. classpath changes like here) and launch configurations for source lookup etc. 

It looks like an awesome feature but right now its just very custom and specific and does not seem build for something that can be used across teams without problems.  


                
> Issue caused by changing editor ID for ClassFileEditor in Juno
> --------------------------------------------------------------
>
>                 Key: JBIDE-13848
>                 URL: https://issues.jboss.org/browse/JBIDE-13848
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: maven
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>         Attachments: test13848.zip
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list