[jbosstools-issues] [JBoss JIRA] (JBIDE-13977) updates/requirements/*/build.xml scripts should include pack.gz artifacts (using p2.process.artifacts pack="true") to make resolving multiple.target faster

Nick Boldt (JIRA) jira-events at lists.jboss.org
Wed Apr 24 18:17:53 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-13977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770028#comment-12770028 ] 

Nick Boldt edited comment on JBIDE-13977 at 4/24/13 6:16 PM:
-------------------------------------------------------------

Looks good but while you're batch-editing files, why not also make sure they all work using the same boilerplate?

They could all be updated to use:

{code} <p2.process.artifacts pack="true" repositoryPath="file:${workDir}" />  {code}

instead of some variation on this:

{code} <p2.process.artifacts pack="true" repositoryPath="file:${destination}/201202240900-SR2" /> {code}

Also not sure you need to update indigo/build.xml or juno/build.xml since we'll never be rebuilding those to include pack.gz artifacts. This change is only for Kepler and beyond.

Please submit a revised PR (or reopen 129 and add/remove commits).

                
      was (Author: nickboldt):
    Looks good but while you're batch-editing files, why not also make sure they all work using the same boilerplate?

They could all be updated to use:

{code} <p2.process.artifacts pack="true" repositoryPath="file:${workDir}" />  {code}

instead of some variation on this:

{code} <p2.process.artifacts pack="true" repositoryPath="file:${destination}/201202240900-SR2" /> {code}

Also not sure you need to update indigo/build.xml or juno/build.xml since we'll never be rebuilding those to include pack.gz artifacts. This change is only for Kepler and beyond.


                  
> updates/requirements/*/build.xml scripts should include pack.gz artifacts (using p2.process.artifacts pack="true") to make resolving multiple.target faster
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13977
>                 URL: https://issues.jboss.org/browse/JBIDE-13977
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng, updatesite, upstream
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>             Fix For: 4.1.0.Beta1
>
>
> All ant scripts (updates/requirements/*/build.xml) used to mirror 3rd party reqs from Eclipse.org and other places should be updated to generate .pack.gz artifacts too.
> {code}<p2.process.artifacts pack="true" repositoryPath="file:/${repoDirLocation}" />{code}
> Refs: 
> * http://git.eclipse.org/c/platform/eclipse.platform.releng.eclipsebuilder.git/plain/scripts/repoRelated/process-artifacts.xml
> * http://help.eclipse.org/juno/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_repositorytasks.htm&cp=2_0_20_3_3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list