[jbosstools-issues] [JBoss JIRA] (JBIDE-14325) Remove UI dependencies from o.j.t.common.core

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker reassigned JBIDE-14325:
-----------------------------------

    Assignee: Alexey Kazakov  (was: Rob Stryker)


Hey Alexey:

Here's a jira for you. If you have any questions, comment here on the jira or on public mailing list for more open discussion. 

The basic idea is to trim the dependency list of o.j.t.common.core to remove anything that may have UI elements. o.j.t.common.core should be 100% free of UI elements and UI dependencies. 
                
> Remove UI dependencies from o.j.t.common.core
> ---------------------------------------------
>
>                 Key: JBIDE-14325
>                 URL: https://issues.jboss.org/browse/JBIDE-14325
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Rob Stryker
>            Assignee: Alexey Kazakov
>            Priority: Critical
>             Fix For: 4.1.0.Beta1
>
>
> One class is polluting o.j.t.common.core with a guaranteed UI class reference. The class in question is org.jboss.tools.common.text.TextProposal. This class should not be in a core plugin at all. 
> This class USED to live in org.jboss.tools.common, but was mistakenly moved to org.jboss.tools.common.core. The package name was NOT changed, so consumers of this class almost 100% did not change their dependencies or depend on teh new LOCATION at all. 
> Moving this class *BACK* to where it was before, while technically an API change, is almost assuredly very very low risk. There is a danger that *NEW* consumers have appeared, and that risk should be considered, but not exaggerated. 
> One other class depends on two jeetools packages which are very large and have a sprawling dependency list. I can not say with certainty whether any UI is pulled in via this reference, but, i feel it is safest to remove it if it can be done in a safe manner. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira