[jbosstools-issues] [JBoss JIRA] (JBIDE-15678) Wrong menu items in menu "Edit" and context menu when Visual Page Editor opened with .xhtml file

[Daniel Azarov (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929065#comment-12929065 ] 

Daniel Azarov edited comment on JBIDE-15678 at 12/5/13 7:40 PM:
----------------------------------------------------------------

action "Mark as Deployable" defined in org.jboss.ide.eclipse.as.ui/plugin.xml
{code}
<extension point="org.eclipse.ui.popupMenus">
	<objectContribution
       adaptable="true"
       id="org.jboss.ide.eclipse.as.ui.popups.makeDeployable.contrib"
       nameFilter="*"
       objectClass="org.eclipse.core.resources.IResource">
      <action
         id="org.jboss.ide.eclipse.as.ui.popups.makeDeployable.action"
         label="Make Publishable"
         icon="$nl$/icons/publish.gif"
         menubarPath="additions"
      class="org.jboss.ide.eclipse.as.ui.actions.DeployAction">
      </action>
   </objectContribution>
</extension>
{code}

This action is visible in context menu on every file in Package Explorer (I think this is correct) and in context menu in text editor and tab Source of every editor twice (I think this is wrong, this action should not be there at all).
I can fix this.


[~rob.stryker], Am I correct? This action is supposed to be visible only in popup (context) menu on files in Package Explorer?
                
      was (Author: dazarov):
    action "Mark is Deployable" defined in org.jboss.ide.eclipse.as.ui/plugin.xml
{code}
<extension point="org.eclipse.ui.popupMenus">
	<objectContribution
       adaptable="true"
       id="org.jboss.ide.eclipse.as.ui.popups.makeDeployable.contrib"
       nameFilter="*"
       objectClass="org.eclipse.core.resources.IResource">
      <action
         id="org.jboss.ide.eclipse.as.ui.popups.makeDeployable.action"
         label="Make Publishable"
         icon="$nl$/icons/publish.gif"
         menubarPath="additions"
      class="org.jboss.ide.eclipse.as.ui.actions.DeployAction">
      </action>
   </objectContribution>
</extension>
{code}

This action is visible in context menu on every file in Package Explorer (I think this is correct) and in context menu in text editor and tab Source of every editor twice (I think this is wrong, this action should not be there at all).
I can fix this.


[~rob.stryker], Am I correct? This action is supposed to be visible only in popup (context) menu on files in Package Explorer?
                  
> Wrong menu items in menu "Edit" and context menu when Visual Page Editor opened with .xhtml file
> ------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-15678
>                 URL: https://issues.jboss.org/browse/JBIDE-15678
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing
>    Affects Versions: 4.1.0.Final
>            Reporter: Daniel Azarov
>            Assignee: Daniel Azarov
>             Fix For: 4.2.0.Alpha2
>
>         Attachments: ContextMenu.png, EditMenu.png
>
>
> Test case:
> 1. Open any .html or .xhtml file in Visual Page Editor
> 2. Check menu "Edit"
> FAIL:
> !EditMenu.png!
> 3. Check context menu
> FAIL:
> !ContextMenu.png!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira