[jbosstools-issues] [JBoss JIRA] (JBIDE-16309) Move inter-JBT dependencies to component poms

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931878#comment-12931878 ] 

Nick Boldt commented on JBIDE-16309:
------------------------------------

Should jbosstools-site-stream be set in each root pom rather than in parent pom so as to break the link/dependency on that definition?

That way the onus is on the project lead to, after branching, set the correct value of jbosstools-site-stream=4.2.luna or jbosstools-site-stream=master so they'll build against the correct upstream stack.

Admittedly it's one more step for leads to remember to do when we branch, AND it complicates a move to the "tag and move on in the same branch" workflow, because you'd have to either:

a) change that value to  jbosstools-site-stream=4.2.luna, tag, change it back to  jbosstools-site-stream=master, and continue 
 - or - 
b) always use jbosstools-site-stream=master, but use commandline override when building locally or in Jenkins for the non-master jobs (formerly _42, now _4.2.luna).

But it also separates further the dependency that projects have on the parent pom.

                
> Move inter-JBT dependencies to component poms
> ---------------------------------------------
>
>                 Key: JBIDE-16309
>                 URL: https://issues.jboss.org/browse/JBIDE-16309
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>             Fix For: 4.2.0.Alpha2
>
>
> It has been discussed several times that the composite site is a kind of "weak point" in our build chain, because it allows cyclic dependencies, and it also introduces indirections that make it less straightforward to find out what a project should/does depend on to build.
> The benefit of composite now seem a bit light: it's cool because we can put it in parent pom and all builds succeed to get there dependencies, but out of that, there hasn't been much other use-cases. And as we want to provide more and more autonomy to project, this composite site they'd depend on is something that doesn't make them autonomous.
> So the idea is to move dependencies to project root poms. I've made a draft of how it would look like in project pom if we remove the "jbosstools-site" from parent pom and let projects manage their inter-dependencies: https://github.com/mickaelistria/jbosstools-javaee/tree/JBIDE-16309
> You can try this by running "mvn clean verify -P\!jbosstools-site". The "-P\!jbosstools-site" disable the jbosstools-site profile, which is the one controlling addition of the composite or ggregate to the resolver
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L423 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira