[jbosstools-issues] [JBoss JIRA] (JBIDE-13438) jboss-packaging-maven-plugin jboss-esb + m2e

[Manosh C (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932429#comment-12932429 ] 

Manosh C commented on JBIDE-13438:
----------------------------------

I implemented the m2e connector for JBoss ESB. This is my first JBoss tools eclipse plugin, it may not be perfect, please give it a shot and let me know.

Here are the changes 

org.jboss.tools.esb.project.core - 
	Patched only one class file, org.jboss.tools.esb.project.core\src\org\jboss\tools\esb\core\facet\JBossESBFacetInstallationDelegate.java, for not to throw an exception if esb related folders exist in the project structure (an utility method is taken from JBossSARFacetInstallationDelegate). I did not find an easy way to package it up, so I copied the whole plugin, patched it and created a feature patch to test on my local.

org.jboss.tools.esb.feature.patch - JBoss ESB tools feature patch (Patch is for the feature org.jboss.tools.esb.feature and version 1.5.302.Final-v20131205-1828-B1209)

org.jboss.tools.maven.jbosspackaging - 
	Refactored into 2 plugins, one is core(org.jboss.tools.maven.jbosspackaging is nothing but the core plugin) and another one is SAR (see below). Core is used in ESB plugin as well.
	MavenSarConstants has been renamed to MavenJBossArchivesConstants to avoid confusion and has been used it in all jboss packaging plugins.
	Reusable things in SarProjectConfigurator have been moved to AbstractJBossArchiveProjectConfigurator, so that AbstractJBossArchiveProjectConfigurator be used for ESB plugin as well.

	SarLifeCycleMapping has been moved to SAR plugin
	SarArchiverConfigurator has been moved to SAR plugin
	SarProjectConfigurator (extends AbstractJBossArchiveProjectConfigurator) has also been moved to SAR plugin

org.jboss.tools.maven.jbosspackaging.feature.patch - Patch for core jboss packaging plugin (Patching the feature org.jboss.tools.maven.jbosspackaging.feature and version 1.5.4.Final-v20131204-2329-B126).

org.jboss.tools.maven.jbosspackaging.sar - M2e Connector for SAR 
org.jboss.tools.maven.jbosspackaging.sar.feature - M2e Connector feature for SAR 

org.jboss.tools.maven.jbosspackaging.esb - M2e Connector for ESB
org.jboss.tools.maven.jbosspackaging.esb.feature - M2e Connector feature for ESB

Note1: Patches only work with a specific version of the existing installed feature. If it needs to be tested with a different version, patch version and plugins included in the patch version have to be changed.

Note2: I have included pom.xml in all projects, unfortunately I could not find a maven repository that contains jboss esb plugins. I could not test tycho build process.

Can someone from JBoss tools team, please review the plugins. If changes look reasonable, can you please merge them back to jboss tools and integration stack.

Attaching the sources and test projects.
Please let me know if you need any further information.
                
> jboss-packaging-maven-plugin jboss-esb + m2e
> --------------------------------------------
>
>                 Key: JBIDE-13438
>                 URL: https://issues.jboss.org/browse/JBIDE-13438
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: esb, integration-platform, maven
>            Reporter: Manosh C
>            Assignee: Brian Fitzpatrick
>             Fix For: 4.2.x
>
>         Attachments: jboss-tools-m2e-esb-sar-sources.zip, test-m2e-esb-sar.zip, testparent.zip
>
>
> Hi,
>  
>      Does jboss-packaging-maven-plugin m2e connector work for jboss-esb? When I import a maven jboss-esb project into eclipse (m2e installed), it does not covert it into an Eclipse JBoss ESB (facet is not enabled and dependecies are not set) project. I tried almost all versions of eclipse, m2e, jboss tools and jboss soa tools, to make it work, but no use. This is my work around for now
>  
> 1. Turn on facet nature and enable JBOSS ESB nature.
> 2. Then it get recognized as a deployable artifact on JBoss server.
> 3. Manually add all dependencies in "Deployment and Assembly section".
>  
> What I was expecting was all steps should have been done by m2e jboss esb (jboss-packaging-maven-plugin) connector. I could not find a relevant post or article related to it. Does this feature ever supported?
>  
> Thank you in advance.
> Manosh

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira