[jbosstools-issues] [JBoss JIRA] (JBIDE-12237) Improve UI of Runtimes dialog

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756297#comment-12756297 ] 

Snjezana Peco commented on JBIDE-12237:
---------------------------------------

{quote}
UnzipOperation is just util that knows nothing about UI, why not just check if location exists and is not empty, then warn in dialog title about owervriting previous version if it is there.
{quote}

The issue hasn't been introduced by this PR.
We don't know if some file/directory exists until we open a zip file. 
I have added the IOverwrite callback interface to the UnzipOperation. It implements the feature you are talking about without adding UI dependencies.

{quote}
One more issue I have with new PR is list of locations to search for runtime is not updated after downloading/unpacking/runtime-creating is done. When I close/open preferences dialog new location where runtime was unpacked becomes visible in list.
{quote}

That issue exists in the old code too. 
The only difference is that the old code contains an additional issue: the progress dialog isn't shown so that the issue isn't prominent.

{quote}
- exception handling (see my notes in PR) 
I would really prefer exceptions like OutOfMemoryException bubble up to be processed somewhere else, not just logged. 
{quote}

Fixed by adding message dialogs.
The issue also hasn't been introduced by this PR.

I have updated the PR.
                
> Improve UI of Runtimes dialog
> -----------------------------
>
>                 Key: JBIDE-12237
>                 URL: https://issues.jboss.org/browse/JBIDE-12237
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: runtime-detection
>    Affects Versions: 3.3.0.Final
>            Reporter: Lucia Jelinkova
>            Assignee: Snjezana Peco
>             Fix For: 4.0.x, 4.1.x
>
>         Attachments: dialog.jpg, JBIDE-12237-download-dialog.png
>
>
> On Runtime detection preferences screen there is a Download button that displays runtimes available for download. The dialog showing those runtimes can be improved, for example:
> * shrink the table and put it into group called Available runtimes or Runtimes available for download
> * change the name of the dialog according to previous point
> * maybe it is not necessary to display the id in this table (does it have any value for the user?)
> * the file size might have - what about adding it into the table?
> * when double clicking the table row, invoke the same action as on OK button
> * what about changing the OK button to Select or Download?
> * what about converting the dialog to some kind of wizard since after clicking "OK" another page is displayed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira