[jbosstools-issues] [JBoss JIRA] (JBIDE-13599) externalize Central site URL into a Preference within Eclipse/JDBS so that testing or mirroring is easier

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756331#comment-12756331 ] 

Max Rydahl Andersen edited comment on JBIDE-13599 at 2/24/13 4:48 PM:
----------------------------------------------------------------------

now i saw the PR this isn't right imo.

there should not be any default set for these.

Make more sense support something similar to what jboss as does.

{{
${<propertyname>:<optionaldefaultvalue>}
}}

which allows:

{{
${jboss.site.url:http://devstudio.jboss.com/yadayda}
}}

{{
${jboss.site.url}
}}

and I believe even nested property replacement are available: 

{{
${jboss.m2e.url:${jboss.base.url}/m2e}
}}

This means he discovery site controls the default and users can explicitly override it and we are not limited to just handling *one* url.

Code to handle this is i believe alrady in server tools code or otherwise I can locate it in AS7 codebase.

And no matter what we do this logic needs *tests* - cannot keep adding code toproject examples without any tests.
                
      was (Author: maxandersen):
    now i saw the PR this isn't right imo.

there should not be any default set for these.

Make more sense support something similar to what jboss as does.

${<propertyname>:<optionaldefaultvalue>}
which allows:
${jboss.site.url:http://devstudio.jboss.com/yadayda}
${jboss.site.url}
and I believe even: ${jboss.m2e.url:${jboss.base.url}/m2e}

This means he discovery site controls the default and users can explicitly override it and we are not limited to just handling *one* url.

Code to handle this is i believe alrady in server tools code or otherwise I can locate it in AS7 codebase.
                  
> externalize Central site URL into a Preference within Eclipse/JDBS so that testing or mirroring is easier
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13599
>                 URL: https://issues.jboss.org/browse/JBIDE-13599
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Snjezana Peco
>             Fix For: 4.1.0.Alpha2
>
>
> As discussed in https://issues.jboss.org/browse/JBDS-2469?focusedCommentId=12755106&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12755106 testing Central is tricky if it's not properly bootstrapped, and bootstrapping is hard when we're on an early Alpha and don't want bits to be public before they've passed QE.
> A better approach than having the update site URL used in Central's discovery plugin.xml hardcoded into that file would be to have it read from a Preference in Eclipse or JBDS. This would allow it to be overwritten/overridden should a user want to test installation from a different URL than the default value. 
> This might even make it possible to have the same discovery plugin used for JBT and JBDS (assuming the list of connectors were the same, and certification was to appear for both instances) simply by having the preference changed to a different default URL when installing JBT or JBDS BYOE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira