[jbosstools-issues] [JBoss JIRA] (JBIDE-13599) externalize Central site URL into a Preference within Eclipse/JDBS so that testing or mirroring is easier

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756502#comment-12756502 ] 

Snjezana Peco commented on JBIDE-13599:
---------------------------------------

{quote}
seriously ? does eclipse plugin.xml resolve $
{propertyname}

against system properties ?
{quote}

No, it doesn't.
$\{org.jboss.central.siteUrl\} is resolved in the code. See DiscoveryViewer.replaceSiteUrl()

{quote}
This means he discovery site controls the default and users can explicitly override it and we are not limited to just handling one url.
{quote}

Do you mean something like the following:

<siteUrl="$\{prop1:defaultprop1\}$\{prop2:defaultprop2\}/m2e">

If prop1 and prop 2 aren't added when running Eclipse, the site url would be as follows:

siteUrl=defaultprop1defaultprop2/m2e

If a user adds:

-Dprop1=XX -Dprop2=YY

the site url would be

siteUrl=XXYY/m2e

?

{quote}
And no matter what we do this logic needs tests - cannot keep adding code toproject examples without any tests.
{quote}

I will create tests.
                
> externalize Central site URL into a Preference within Eclipse/JDBS so that testing or mirroring is easier
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13599
>                 URL: https://issues.jboss.org/browse/JBIDE-13599
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Snjezana Peco
>             Fix For: 4.1.0.Alpha2
>
>
> As discussed in https://issues.jboss.org/browse/JBDS-2469?focusedCommentId=12755106&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12755106 testing Central is tricky if it's not properly bootstrapped, and bootstrapping is hard when we're on an early Alpha and don't want bits to be public before they've passed QE.
> A better approach than having the update site URL used in Central's discovery plugin.xml hardcoded into that file would be to have it read from a Preference in Eclipse or JBDS. This would allow it to be overwritten/overridden should a user want to test installation from a different URL than the default value. 
> This might even make it possible to have the same discovery plugin used for JBT and JBDS (assuming the list of connectors were the same, and certification was to appear for both instances) simply by having the preference changed to a different default URL when installing JBT or JBDS BYOE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira