[jbosstools-issues] [JBoss JIRA] (JBIDE-13628) Only one JBoss Central Configurator is selected for display

Max Rydahl Andersen (JIRA) jira-events at lists.jboss.org
Wed Feb 27 13:41:56 EST 2013


    [ https://issues.jboss.org/browse/JBIDE-13628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757301#comment-12757301 ] 

Max Rydahl Andersen edited comment on JBIDE-13628 at 2/27/13 1:39 PM:
----------------------------------------------------------------------

Wizards are not supposed to be added to central by other plugins. Only wizards that comes in via jboss way/jboss developer framework. In JBT 4.0/JBDS 6 these are a fixed set.

In JBT 4.1.x/JBDS 7 we want to add to central the option of showing wizards for things that are not even installed - i.e. "Teiid Project" which will tell user to install Teiid Plugin to get this. Thus the dependency is the other way around.

Thus i'm going to reject this as "work as expected".
                
      was (Author: maxandersen):
    Wizards are not supposed to be added to central by other plugins. Only wizards that comes in via jboss way/jboss developer framework. In JBT 4.0/JBDS 6 this are fixed.

In JBT 4.1.x we want to add to central the option of showing wizards for things that are not even installed - i.e. "Teiid Project" which will tell user to install Teiid Plugin to get this. Thus the dependency is the other way around.

Thus i'm going to reject this as "work as expected".
                  
> Only one JBoss Central Configurator is selected for display
> -----------------------------------------------------------
>
>                 Key: JBIDE-13628
>                 URL: https://issues.jboss.org/browse/JBIDE-13628
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: central
>            Reporter: Paul Richardson
>            Assignee: Max Rydahl Andersen
>            Priority: Minor
>             Fix For: 4.1.0.Alpha1
>
>
> I wanted to contribute Teiid Designer's 'new model project' wizard as a link in the 'Create Projects' section of JBoss Central. [link|http://www.phantomjinx.co.uk/stuff/jboss-central.png]
> However, I found that the list of project wizards is hard-coded in the default configurator [1]. Thus, the only way I can contribute this link is by extending the default configurator and using the configurators extension point[2] to load my configurator.
> This works correctly but if another project decides to do the same thing then their configurator 'could' be loaded instead of mine due to the following logic in [3]:
> {code:title=ProjectExamplesActivator.java|borderStyle=solid}
> // ... ~ Line 1163
> IExtension extension = extensions[0];
> IConfigurationElement[] configurationElements = extension.getConfigurationElements();
> for (int j = 0; j < configurationElements.length; j++) {
>   IConfigurationElement configurationElement = configurationElements[j];
>   if (CONFIGURATOR.equals(configurationElement.getName())) {
>     try {
>       configurator = (IJBossCentralConfigurator) configurationElement.createExecutableExtension("class");
>     } catch (CoreException e) {
>       ProjectExamplesActivator.log(e);
>       continue;
>     }
>     break;
>   }
> }
> // ...
> {code}
>  
> Thought an alternative configurator that aggregates all extension-pointed configurators and displays the content of each accordingly.
> Happy to provide a patch if required.
> [1] org.jboss.tools.project.examples.configurators.DefaultJBossCentralConfigurator
> [2] org.jboss.tools.project.examples.configurators
> [3] org.jboss.tools.project.examples.ProjectExamplesActivator.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list