[jbosstools-issues] [JBoss JIRA] (JBIDE-13343) org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest.testGetFavoritesClassesList fails

Viacheslav Kabanovich (JIRA) jira-events at lists.jboss.org
Fri Jan 4 15:29:08 EST 2013 

    [ https://issues.jboss.org/browse/JBIDE-13343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743616#comment-12743616 ] 

Viacheslav Kabanovich commented on JBIDE-13343:
-----------------------------------------------

Test class FavoritesClassControllerTest tests org.jboss.tools.common.core.jdt.FavoritesClassController, which is used by only org.jboss.tools.common.model.ui.attribute.editor.JavaFavoritesFieldEditor, which is not used anywhere and is not supported since 2007.
Formally, they are part of API, but only 2+2=4 can be more certain than the assumption that nobody in the universe considered using or subclassing them.
It is a simple matter to fix the test, which fails with Java 1.7 because it depends on order in which test methods run; but may we instead git rid of the dead code? Guys, please vote.


                
> org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest.testGetFavoritesClassesList fails
> ---------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13343
>                 URL: https://issues.jboss.org/browse/JBIDE-13343
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: common/jst/core
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Daniel Azarov
>            Assignee: Viacheslav Kabanovich
>             Fix For: 4.1.0.Alpha1
>
>
> On my computer this test fails with ~30% probability
> {code}
> -------------------------------------------------------------------------------
> Test set: org.jboss.tools.common.model.ui.test.ModelUiAllTests
> -------------------------------------------------------------------------------
> Tests run: 19, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.457 sec <<< FAILURE!
> testMainPreferencesPage(org.jboss.common.model.ui.test.preferences.ModelUiPreferencesPageTest)  Time elapsed: 0.117 sectestDecoratorPreferencesPage(org.jboss.common.model.ui.test.preferences.ModelUiPreferencesPageTest)  Time elapsed: 0.109 sectestCompanyPreferencesPage(org.jboss.common.model.ui.test.preferences.ModelUiPreferencesPageTest)  Time elapsed: 0.108 sectestGlobalTemplatesPreferencesPage(org.jboss.common.model.ui.test.preferences.ModelUiPreferencesPageTest)  Time elapsed: 0.599 sectestEditorsPreferencesPage(org.jboss.common.model.ui.test.preferences.ModelUiPreferencesPageTest)  Time elapsed: 0.118 sectestObjectDecoratorFixMe(org.jboss.tools.common.model.ui.test.ObjectDecoratorTest)  Time elapsed: 0.007 sectestPush(org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest)  Time elapsed: 0.02 sectestGetLabelProvider(org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest)  Time elapsed: 0 sectestGetFavoritesClassesList(org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest)  Time elapsed: 0.003 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<0> but was:<3>
> 	at junit.framework.Assert.fail(Assert.java:50)
> 	at junit.framework.Assert.failNotEquals(Assert.java:287)
> 	at junit.framework.Assert.assertEquals(Assert.java:67)
> 	at junit.framework.Assert.assertEquals(Assert.java:199)
> 	at junit.framework.Assert.assertEquals(Assert.java:205)
> 	at org.jboss.tools.common.core.jdt.test.FavoritesClassControllerTest.testGetFavoritesClassesList(FavoritesClassControllerTest.java:24)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:601)
> 	at junit.framework.TestCase.runTest(TestCase.java:168)
> 	at junit.framework.TestCase.runBare(TestCase.java:134)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:243)
> 	at junit.framework.TestSuite.run(TestSuite.java:238)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:243)
> 	at junit.framework.TestSuite.run(TestSuite.java:238)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> 	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:601)
> 	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
> 	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
> 	at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:175)
> 	at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:123)
> 	at org.eclipse.tycho.surefire.osgibooter.OsgiSurefireBooter.run(OsgiSurefireBooter.java:85)
> 	at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication$1.run(AbstractUITestApplication.java:35)
> 	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> 	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> 	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3529)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3182)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1022)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:916)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86)
> 	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:585)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:540)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> 	at org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
> 	at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
> 	at org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:601)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
> 	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
> testCancelPressed(org.jboss.tools.common.model.ui.dialog.test.ErrorDialogTest)  Time elapsed: 0.041 sectestOkPressed(org.jboss.tools.common.model.ui.dialog.test.ErrorDialogTest)  Time elapsed: 0.022 sectestErrorDialogShellStringStringThrowable(org.jboss.tools.common.model.ui.dialog.test.ErrorDialogTest)  Time elapsed: 0.047 sectestErrorDialogShellStringThrowable(org.jboss.tools.common.model.ui.dialog.test.ErrorDialogTest)  Time elapsed: 0.044 sectestButtonPressed(org.jboss.tools.common.model.ui.dialog.test.ErrorDialogTest)  Time elapsed: 0.044 sectestDialogMultiCheckBox(org.jboss.tools.common.model.ui.dialog.test.MessageAndCheckboxDialogTest)  Time elapsed: 0.028 sectestDialogMultiCheckBoxNoSeparator(org.jboss.tools.common.model.ui.dialog.test.MessageAndCheckboxDialogTest)  Time elapsed: 0.031 sectestButtonPressed(org.jboss.tools.common.model.ui.dialog.test.MessageAndCheckboxDialogTest)  Time elapsed: 0.041 sectestDialogSingleCheckBox(org.jboss.tools.common.model.ui.dialog.test.MessageAndCheckboxDialogTest)  Time elapsed: 0.025 sectestOpenJarProperties(org.jboss.tools.common.model.ui.jarproperties.JarPropertiesTest)  Time elapsed: 5.02 sec
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the jbosstools-issues mailing list