[jbosstools-issues] [JBoss JIRA] (JBIDE-13329) should unified.target includes sources?

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744990#comment-12744990 ] 

Nick Boldt commented on JBIDE-13329:
------------------------------------

Should not remove sdkbundle as jbt gwt stuff requires it. Could include the plugin if you want to omit the feature, I suppose.

{code}
** [1] ./plugins/org.jboss.tools.gwt.core/META-INF/MANIFEST.MF **
9- org.jboss.tools.common;bundle-version="[3.2.0,4.0.0)",
10- com.google.gwt.eclipse.core,
11: com.google.gwt.eclipse.sdkbundle;bundle-version="[2.4.0,3.0.0)",
12- com.google.gdt.eclipse.suite;bundle-version="3.0.1",
13- org.eclipse.core.runtime;bundle-version="[3.5.0,4.0.0)",

** [2] ./plugins/org.jboss.tools.gwt.core/src/org/jboss/tools/gwt/core/IGoogleEclipsePluginConstants.java **
57- public static final String WELCOME_FILE = "Gwt_jboss.html"; //$NON-NLS-1$
58-
59: public static final String GWT_SDK_BUNDLENAME = "com.google.gwt.eclipse.sdkbundle"; //$NON-NLS-1$
60-
61- public static final String GWT_SERVLET_NAME = "gwt-servlet.jar"; //$NON-NLS-1$
{code}
                
> should unified.target includes sources?
> ---------------------------------------
>
>                 Key: JBIDE-13329
>                 URL: https://issues.jboss.org/browse/JBIDE-13329
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.0.0.Final
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>             Fix For: 4.1.0.Alpha1
>
>
> I was under the impression that the generated multiple.target would include source features, while the generated unified.target would not.
> However:
> {code}
> unified-4.2.1.a-20121220.173723-14-unified.target:  
>   <location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> multiple-4.2.1.a-20121220.173233-14-multiple.target: 
>   <location includeAllPlatforms="false" includeMode="planner" type="InstallableUnit" includeSource="true">
> {code}
> And the generated update site for 4.2.1.a (SR1a) target platform contains many feature.source bundles:
> http://download.jboss.org/jbosstools/updates/juno/SR1a/REPO/features/
> Is this intentional? Or is there a bug in your flatten mojo?
> https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FlattenTargetMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira