[jbosstools-issues] [JBoss JIRA] (JBIDE-13329) should unified.target includes sources?

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745333#comment-12745333 ] 

Nick Boldt commented on JBIDE-13329:
------------------------------------

We need multiple versions of the publish.sh script for 4.0 and 4.1 streams. Or the script has to know about 4.2.0.*, 4.2.1.* and 4.3.0.M4 for JBT and JBDS. 

So either we need to commit your changes for 4.2.x into the 4.x branch of jbosstools-build/target-platforms (which IMHO makes sense because master branch won't care about 4.2.x TPs), or we need that the master branch have 3+ TP definitions for 4.2, 4.2.x, and 4.3.0.latestMilestone (currently M4 but will need to add M5 the week of Feb 8).

I would recommend we keep the 4.0/4.2/Juno stuff in the 4.x branch (and adjust the TP jobs accordingly) and keep the 4.1/4.3/Kepler in master, and not cross the streams. Because as you know, crossing the streams is bad. 

http://www.imdb.com/title/tt0087332/quotes?qt=qt0475898
                
> should unified.target includes sources?
> ---------------------------------------
>
>                 Key: JBIDE-13329
>                 URL: https://issues.jboss.org/browse/JBIDE-13329
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.0.0.Final
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>             Fix For: 4.1.0.Alpha1
>
>
> I was under the impression that the generated multiple.target would include source features, while the generated unified.target would not.
> However:
> {code}
> unified-4.2.1.a-20121220.173723-14-unified.target:  
>   <location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> multiple-4.2.1.a-20121220.173233-14-multiple.target: 
>   <location includeAllPlatforms="false" includeMode="planner" type="InstallableUnit" includeSource="true">
> {code}
> And the generated update site for 4.2.1.a (SR1a) target platform contains many feature.source bundles:
> http://download.jboss.org/jbosstools/updates/juno/SR1a/REPO/features/
> Is this intentional? Or is there a bug in your flatten mojo?
> https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FlattenTargetMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira