[jbosstools-issues] [JBoss JIRA] (JBIDE-13329) should unified.target includes sources?

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746210#comment-12746210 ] 

Mickael Istria commented on JBIDE-13329:
----------------------------------------

So which branch should be updated. It's quite difficult to apply suggested PR on master because it's conflicting with the Kepler commit.
About crossing the streams, it makes me more and more in favor of:
* Removing the minimal and maximal profiles in TP parent pom, and choose the child pom directly in builds
* keep all TPs in branch instead of removing the "older" one.

I'm starting to be convinced that the way we deal with TPs in the jbosstools-build repository is very hacky and difficult to maintain. I'll probably soon set up a jbosstools-target-platforms reposioty where 1 branch = 1 version of TP...
                
> should unified.target includes sources?
> ---------------------------------------
>
>                 Key: JBIDE-13329
>                 URL: https://issues.jboss.org/browse/JBIDE-13329
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: target-platform
>    Affects Versions: 4.0.0.Final
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>             Fix For: 4.1.0.Alpha1
>
>
> I was under the impression that the generated multiple.target would include source features, while the generated unified.target would not.
> However:
> {code}
> unified-4.2.1.a-20121220.173723-14-unified.target:  
>   <location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
> multiple-4.2.1.a-20121220.173233-14-multiple.target: 
>   <location includeAllPlatforms="false" includeMode="planner" type="InstallableUnit" includeSource="true">
> {code}
> And the generated update site for 4.2.1.a (SR1a) target platform contains many feature.source bundles:
> http://download.jboss.org/jbosstools/updates/juno/SR1a/REPO/features/
> Is this intentional? Or is there a bug in your flatten mojo?
> https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FlattenTargetMojo.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira