[jbosstools-issues] [JBoss JIRA] (JBIDE-13246) When two servers with same version are found only one is added

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750910#comment-12750910 ] 

Max Rydahl Andersen commented on JBIDE-13246:
---------------------------------------------

The past obviously failed on keeping these bugs a bay - best source of that is the lack of tests.

QE's tests have moved out but that does not mean the component itself should have tests for its basic functionality.

My understanding was that runtime detection now is done at core level and things like this should not be present/done in UI so that surprises me if that is still the case.

Looking at the code this specific patch concerns fixing a UI bug where it seem to be calling a method that is bogus in the branch (getRuntimeDefinitions() vs RuntimeModelUtil.getAllDefinitions(runtimePaths.toArray(new RuntimePath[0]));) but then continues to call the local getRuntimeDefinitions....so the patch on its own is rather mysterious.

That said, the test i'm still missing is where are the test in runtime detection unit tests (i.e. RuntimeModelUtil) that verifies this logic about two servers with same version found actual result in getAllDefinitions() (and what else methods needed) to return the right result and get the right number of servers created ?

That does not sound to me like it needs a UI test ?


                
> When two servers with same version are found only one is added 
> ---------------------------------------------------------------
>
>                 Key: JBIDE-13246
>                 URL: https://issues.jboss.org/browse/JBIDE-13246
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection
>    Affects Versions: 4.0.0.CR1
>            Reporter: Petr Suchý
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.1.0.Alpha1, 4.0.x
>
>
> Regression - JBIDE-12714
> When I add a path that contains two servers with the same type and version, both are correctly listed as found but just one is added. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira