[jbosstools-issues] [JBoss JIRA] (JBIDE-13425) Enhance astools api to centralize default launch arguments

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750939#comment-12750939 ] 

Rob Stryker commented on JBIDE-13425:
-------------------------------------

I have carefully done the following:
  1) created a new semi-api (provincial api?) inside the extended server properties to house things such as default launch args and stop args
  2) I have redirected all old uses to the new use, and have marked the old apis as deprecated
  3) I have marked some of our internal protected methods as deprecated, specifically 4 in the server behavior delegate classes which were found to be confusing the flow of logic and execution.
  4) A bug years ago caused us to have to set a server's mode to STARTING before it could be set to STARTED.  While I cannot find the bugzilla for this old entry, the effect this had was that if we were ignoring launches, we must set it to STARTING before STARTED.  Unfortunately, this would have the effect of launching a ping thread even when we didnt want to (also internal, since when the server is set to starting is when we launch the ping thread).  In these instances, and since the upstream bug has been fixed (revealed through ample tracing), the call to starting is not necessary, adn we can set directly to started. 
  5) Small differences between the various class heirarchies were investigated to see if they were there for a purpose or if they were an oversight. Many were unified and the overriding subclass's method was removed in favor of the super-classes fixed impl. 
  6) Obscure use cases such as starting the server outside of the workspace (and the server editor having the 'externally launched' checkbox checked) were also investigated, so that their logic could be extended to as7. (example, in these cases, using a shutdown poller of watching for a terminated process did not work and a different poller would need to be used)


Issues regarding api compatability:
  1) Removed 2 unused constants in LocalJBoss71ServerRuntime, a very internal class nobody should be referencing
  2) A very internal class RSEJBoss7LaunchConfigurator has had some of its protected method signatures changed. 
  3) RSELaunchConfigurator had its constructor changed. This is not a class anyone should be instantiating anywhere. 

All other changes were made in such a way as to maintain binary compatability. 

This was tested by manually starting 8 different server types both locally, remotely, locally with 'skip launch' flag, and remotely via cmd line and then in eclipse with 'skip launch' flag. 
                
> Enhance astools api to centralize default launch arguments 
> -----------------------------------------------------------
>
>                 Key: JBIDE-13425
>                 URL: https://issues.jboss.org/browse/JBIDE-13425
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: JBossAS/Servers
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.1.0.Alpha1
>
>
> Runtime interface, and behavior delegates, are full of code involving default start and stop launch arguments. These should be centralized in an interface accessible via the extended properties model. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira