[jbosstools-issues] [JBoss JIRA] (JBIDE-14780) Add ShrinkWrap Archive name/type validation

[Max Rydahl Andersen (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Rydahl Andersen updated JBIDE-14780:
----------------------------------------

    Fix Version/s: 4.1.x
                   4.2.x
                       (was: 4.1.0.CR1)


no more features making it in to block GA. Arquillian is marked as experimental thus not blocking unless serious critical unsuable issue.

If you believe this issue *must* be fixed before GA please set fix version to CR1 and provide patch/reason.
                
> Add ShrinkWrap Archive name/type validation
> -------------------------------------------
>
>                 Key: JBIDE-14780
>                 URL: https://issues.jboss.org/browse/JBIDE-14780
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: testing-tools
>            Reporter: Aslak Knutsen
>            Assignee: Snjezana Peco
>             Fix For: 4.1.x, 4.2.x
>
>
> *Given*
> {code}
> ShrinkWrap.create(WebArchive.class, "test.jar")
> ShrinkWrap.create(WebArchive.class, "test.ear")
> ShrinkWrap.create(JavaArchive.class, "test.ear")
> ShrinkWrap.create(WebArchive.class, "test")
> {code}
> *When*
> User is creating a Archive
> *Then*
> The known Archive types should match given archive name extensions.
> *Expected*
> Warning; Creating an archive of type WebArchive but given name does not match to predefined name extension; .war
> *Actual*
> Nothing.. waits for Arquillian to fail. 
> This is a very common and annoying user error. The Container/Server will 99% of the time rely on the deployment file extension to determine what type of archive this is. While our 'WebArchive' Archive types are only convenience views on how to add data to correct locations within the target archive and can be any type; we choose to validate this runtime in Arquillian core to warn that 'hey, this is probably not what you intended to do' to hopefully save users from a few hours pointless debugging. 
> See https://github.com/arquillian/arquillian-core/blob/master/container/spi/src/main/java/org/jboss/arquillian/container/spi/client/deployment/Validate.java#L45 for our extension type mapping.
> Our validation logic is; if extension does not match, but Archive is of Type then warn. 
> That allows users to use Custom views without warning.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira