[jbosstools-issues] [JBoss JIRA] (JBIDE-15115) No confirmation dialog is reported back to user after embedding cartridges

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787313#comment-12787313 ] 

Andre Dietisheim commented on JBIDE-15115:
------------------------------------------

The cause to this is not a timeout but an NPE. The NPE was not reported to the user, the wizard was imply not closing, logging and error-dialog were missing in the wizard:

{code:title=EmbedCartridgeWizardPage}
	public boolean processCartridges() {
		try {
			EmbedCartridgesJob job = new EmbedCartridgesJob(
					new ArrayList<IEmbeddableCartridge>(pageModel.getSelectedEmbeddableCartridges()), 
					pageModel.getApplication());
			IStatus result = WizardUtils.runInWizard(job, job.getDelegatingProgressMonitor(), getContainer(), EMBED_CARTRIDGES_TIMEOUT);
			if (!result.isOK()) {
				safeRefreshSelectedEmbeddedCartridges();
			} else {
				openLogDialog(job.getAddedCartridges(), job.isTimeouted(result));
			}
			return result.isOK();
		} catch (Exception e) {
			return false;
		}
{code}
                
> No confirmation dialog is reported back to user after embedding cartridges
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-15115
>                 URL: https://issues.jboss.org/browse/JBIDE-15115
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.CR1
>            Reporter: Stefan Bunciak
>            Priority: Critical
>              Labels: respin-a
>             Fix For: 4.1.0.CR1
>
>
> No error log is put to Error log view neither to workspace log when experiencing this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira