[jbosstools-issues] [JBoss JIRA] (JBIDE-15149) 9 test failures in as.core and as.internal.management

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788341#comment-12788341 ] 

Rob Stryker commented on JBIDE-15149:
-------------------------------------

As Denis said, several of the tests are requiring a java7 location in the property. For the remaining few issues that do not require that (as far as I can see), it is simply an error in test logic. 

Specifically, 3 tests with signature  ServerBeanLoader3Test.testServerBeanLoaderFromRuntimes  are failing because they are being run against more specific mock types which do not have runtimes passed in (stuff like jpp, gate-in, etc) and this test should not be running against those. 

It'd be a 1 or 2 line patch to fix the test for those 3 fails. 

The test method should be updated as follows:

{code}
	public void testServerBeanLoaderFromRuntimes() {
		String fLoc = TestConstants.getServerHome(serverType);
		if( fLoc == null ) {
			if( Arrays.asList(IJBossToolingConstants.ALL_JBOSS_SERVERS).contains(serverType)) {
				// This type should be tested but has no server-home, so fail
				fail("Test Suite has no server home for server type " + serverType);
			}
			// IF we're not one of the standard types, we're a test type (jpp, gate-in, etc), and this isn't a fail
			return;
		}
		Pair p = expected.get(serverType);
		inner_testServerBeanLoaderForFolder(new File(fLoc), p.type, p.version);
		if( p.type.equals(JBossServerType.EAP_STD)) {
			inner_testServerBeanLoaderForFolder(new File(fLoc).getParentFile(), JBossServerType.EAP, p.version);
		}
	}
{code}

Not sure if we need a PR for this or a re-spin or what. 
                
> 9 test failures in as.core and as.internal.management
> -----------------------------------------------------
>
>                 Key: JBIDE-15149
>                 URL: https://issues.jboss.org/browse/JBIDE-15149
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.1.0.CR1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Blocker
>              Labels: respin-b
>             Fix For: 4.1.0.CR1
>
>
> Failing for the past *5* builds:
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_7.0.kepler/job/jbosstools-server_41/92/testReport/}
> All Failed Tests
> Test Name   	Duration   	Age   
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagementServiceStartupShutdownTest.dummyTest[2] 	3.1 sec	5
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagerIntegrationTest.canGetServerState[2] 	3.1 sec	5
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagerIntegrationTest.getDisabledStateIfDeploymentIsOnlyAdded[2] 	5 ms	5
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagerIntegrationTest.getErrorIfDeploymentIsNotDeployed[2] 	5 ms	5
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagerIntegrationTest.deployedWarIsResponding[2] 	4 ms	5
> >>> org.jboss.ide.eclipse.as.internal.management.as7.tests.AS7ManagerIntegrationTest.getEnabledStateIfDeploymentIsDeployed[2] 	5 ms	5
> >>> org.jboss.tools.as.test.core.parametized.server.ServerBeanLoader3Test.testServerBeanLoaderFromRuntimes[13] 	9 ms	5
> >>> org.jboss.tools.as.test.core.parametized.server.ServerBeanLoader3Test.testServerBeanLoaderFromRuntimes[14] 	4 ms	5
> >>> org.jboss.tools.as.test.core.parametized.server.ServerBeanLoader3Test.testServerBeanLoaderFromRuntimes[15] 	5 ms	5
> {code}
> Please investigate these ASAP and decide if a respin-b is needed to fix anything here (or if it's just the tests that need to be fixed).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira