[jbosstools-issues] [JBoss JIRA] (JBIDE-15156) Unable to add Tomcat server after installing JBT over non Eclipse Java EE distros

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788605#comment-12788605 ] 

Nick Boldt edited comment on JBIDE-15156 at 7/9/13 12:30 PM:
-------------------------------------------------------------

Here's what we did in Central [1] to expose this dependency for connectors which depend on it (but don't declare it properly, like JRebel [2]):

[1] https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery/plugin.xml#L127
[2] https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery/plugin.xml#L524

So, if you need org.eclipse.jst.server_adapters.feature for the org.jboss.tools.wtp.runtimes.tomcat plugin, you should declare a dependency on it in your feature's feature.xml - or even better, the plugin should declare all the upstream PLUGINS on which it depends, not just the feature declaring a dep on an upstream feature.

I assume we're taking about these?

https://github.com/jbosstools/jbosstools-server/tree/jbosstools-4.1.x/wtp/plugins/org.jboss.tools.wtp.runtimes.tomcat/META-INF/MANIFEST.MF
https://github.com/jbosstools/jbosstools-server/tree/jbosstools-4.1.x/wtp/features/org.jboss.tools.wtp.runtimes.tomcat.feature/feature.xml

                
      was (Author: nickboldt):
    Here's what we did in Central [1] to expose this dependency for connectors which depend on it (but don't declare it properly, like JRebel [2]):

[1] https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery/plugin.xml#L127
[2] https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery/plugin.xml#L524

So, if you need org.eclipse.jst.server_adapters.feature for the , you should declare a dependency on it in your feature's feature.xml

I assume that's jbosstools-server/wtp/features/org.jboss.tools.wtp.runtimes.tomcat.tests.feature/feature.xml ?
                  
> Unable to add Tomcat server after installing JBT over non Eclipse Java EE distros
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-15156
>                 URL: https://issues.jboss.org/browse/JBIDE-15156
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>            Reporter: Ilya Buziuk
>             Fix For: 4.1.0.CR1
>
>         Attachments: icons.png, serverError.png
>
>
> There is no possibility of specifying the installation directory of Tomcat server. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira