[jbosstools-issues] [JBoss JIRA] (JBIDE-15157) Dont get credentials for mysql if I also embed phpmyadmin into a scalable application

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788687#comment-12788687 ] 

Andre Dietisheim commented on JBIDE-15157:
------------------------------------------

The error here is that the tooling stops all processing once it hits an error. 
In this usecase mysql is successfully embedded before it tries to phpmyadmin. Phpmyadmin then fails because it may not get embedded into scalable applications. The tooling should not break, it should continue embedding once it hits an error. It should collect all errors and report them once all cartridges were processed (successfully or not).
This unfortunately requires a change in the openshift-java-client. The current implementation in java-client does not collect exceptions that may occourr, it simply breaks out of the loops and throws the error further.

{code:title=ApplicationResource}
for (IEmbeddableCartridge cartridge : cartridges) {
	// TODO: catch exceptions when removing cartridges, contine removing
	// and report the exceptions that occurred
	addedCartridge.add(addEmbeddableCartridge(cartridge));
}
return addedCartridge;
{code}
                
> Dont get credentials for mysql if I also embed phpmyadmin into a scalable application
> -------------------------------------------------------------------------------------
>
>                 Key: JBIDE-15157
>                 URL: https://issues.jboss.org/browse/JBIDE-15157
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.CR1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 4.2.0.Alpha1
>
>         Attachments: phpmyadmin-not-scalable.png
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira