[jbosstools-issues] [JBoss JIRA] (JBIDE-15205) OpenShift menu contribution issue

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790495#comment-12790495 ] 

Snjezana Peco commented on JBIDE-15205:
---------------------------------------

The issue isn't always reproducible. It is related to the activation of the org.jboss.tools.openshift.express.ui plugin.
If the plugin is active when starting JBDS/JBT, the OpenShift menu contribution works as expected.
The issue happens when the plugin isn't activated at startup.

I can always reproduce the issue using JBoss Tools 4.1.0.RC1 as well as in the PDE with the JBT master branch.
The menu is shown even for a closed project.
Try the following in JBDS:

- create a non-OpenShift project
- open the Java perspective (make sure the OpenShift Explorer view isn't visible)
- close JBDS
- remove $JBDS_HOME/studio/configuration/.settings
- start JBDS in the old workspace
- open the OSGi console view
- enter "ss org.jboss.tools.openshift.express.ui"

If the plugin is in the STARTING mode, you will be able to reproduce the issue.

If you call "start org.jboss.tools.openshift.express.ui" in the Host OSGi console view, the plugin will be activated and the issue will disappear.

In the http://screencast.com/t/NYsRShpBV screencast, I have used JBT master. 

The PR fixes the issue no matter if the plugin is activated at startup or not.
The PR is updated.

                
> OpenShift menu contribution issue
> ---------------------------------
>
>                 Key: JBIDE-15205
>                 URL: https://issues.jboss.org/browse/JBIDE-15205
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: openshift
>    Affects Versions: 4.1.0.CR1
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>             Fix For: 4.1.1.Final, 4.2.0.Alpha1
>
>         Attachments: package-explorer-nonopenshift.png, package-explorer-openshift.png, project-explorer-nonopenshift.png, project-explorer-openshift.png
>
>
> The OpenShift menu contribution is visible when right-clicking any Eclipse project (not only an OpenShift project).
> The issue happens because the org.jboss.tools.openshift.express.ui.openshiftProjectPropertyTester property tester isn't declared correctly.
> Also, its icon (marker.png) is too large for a context menu action.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira