[jbosstools-issues] [JBoss JIRA] (JBIDE-15256) Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement

[Denis Golovin (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793252#comment-12793252 ] 

Denis Golovin commented on JBIDE-15256:
---------------------------------------

It is moving in pluginManagenent section not plugins sections and it means it is not going to be applied to every module. 
Just try the PR and see if it works.
                
> Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-15256
>                 URL: https://issues.jboss.org/browse/JBIDE-15256
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: Build/Releng
>    Affects Versions: 4.2.0.Alpha1
>            Reporter: Denis Golovin
>            Assignee: Denis Golovin
>             Fix For: 4.2.0.Alpha1
>
>
> Currently every feature's pom.xml includes the same code, which is code-duplication issue.
> {code}
> <plugin>
> 	<groupId>org.eclipse.tycho.extras</groupId>
> 	<artifactId>tycho-source-feature-plugin</artifactId>
> 	<version>${tychoExtrasVersion}</version>
> 	<executions>
> 		<execution>
> 			<id>source-feature</id>
> 			<phase>package</phase>
> 			<goals>
> 				<goal>source-feature</goal>
> 			</goals>
> 		</execution>
> 	</executions>
> </plugin>
> <plugin>
> 	<groupId>org.eclipse.tycho</groupId>
> 	<artifactId>tycho-p2-plugin</artifactId>
> 	<version>${tychoVersion}</version>
> 	<executions>
> 		<execution>
> 			<id>attached-p2-metadata</id>
> 			<phase>package</phase>
> 			<goals>
> 				<goal>p2-metadata</goal>
> 			</goals>
> 		</execution>
> 	</executions>
> </plugin>{code}
> It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to 
> {code}<plugin>
> 	<groupId>org.eclipse.tycho.extras</groupId>
> 	<artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> 	<groupId>org.eclipse.tycho</groupId>
> 	<artifactId>tycho-p2-plugin</artifactId>
> </plugin>{code}
> in every feture's pom.xml file. 
> More over code above could be moved to to features/pom.xml as
> {code}<build>
> 	<plugins>
> 		<plugin>
> 			<groupId>org.eclipse.tycho.extras</groupId>
> 			<artifactId>tycho-source-feature-plugin</artifactId>
> 		</plugin>
> 		<plugin>
> 			<groupId>org.eclipse.tycho</groupId>
> 			<artifactId>tycho-p2-plugin</artifactId>
> 		</plugin>
> 	</plugins>
> </build>{code}
> that would let keep pom.xml for every feature even cleaner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira