[jbosstools-issues] [JBoss JIRA] (JBIDE-14721) openshift-java-client: correct alias-integration tests to add valid aliases

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-14721:
----------------------------------------

             Summary: openshift-java-client: correct alias-integration tests to add valid aliases
                 Key: JBIDE-14721
                 URL: https://issues.jboss.org/browse/JBIDE-14721
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: openshift
    Affects Versions: 4.1.0.Beta2
            Reporter: Andre Dietisheim
            Assignee: Andre Dietisheim
             Fix For: 4.1.0.Beta2


openshift-java-client integration test against DEVENV started to fail when OpenShift changed validity rules for aliases:

{code}
Tests in error:
  shouldAddAliasToApplication(com.openshift.internal.client.ApplicationResourceIntegrationTest): Could not request https://ec2-107-20-110-143.compute-1.amazonaws.com/broker/rest/domains/1370028343009/applications/1370028873585/events: null=Operation failed with exit code "105".Reason given: "Invalid Server Alias '1370029105965' specified"(..)
  shouldRemoveAliasOfApplication(com.openshift.internal.client.ApplicationResourceIntegrationTest): Could not request https://ec2-107-20-110-143.compute-1.amazonaws.com/broker/rest/domains/1370028343009/applications/1370028873585/events: null=Operation failed with exit code "105".Reason given: "Invalid Server Alias '1370029106182' specified"(..)
{code}

In bug https://bugzilla.redhat.com/show_bug.cgi?id=968952 the OpenShift team changed the regex that validates aliases (see https://bugzilla.redhat.com/show_bug.cgi?id=968952#c4):

{code}
" /\A[a-z0-9]+(-[a-z0-9]+)*(\.[a-z0-9]+(-[a-z0-9]+)*)+\z/"
{code}

The openshift-java-client integration tests fail when *adding* aliases in the form of 13 numerical characters (ex. "1370029105965") 
Since we dont want to replicate the server logic we'll simply change the integration tests to add valid aliases and add another integration test that's expected to fail

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira