[jbosstools-issues] [JBoss JIRA] (JBIDE-14751) jQuery Popup Wizard should let select Theme w/o Shadow selected

Alexey Kazakov (JIRA) jira-events at lists.jboss.org
Tue Jun 4 20:55:54 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779360#comment-12779360 ] 

Alexey Kazakov commented on JBIDE-14751:
----------------------------------------

data-theme="none" + data-shadow="false" is useful when the popup contains an image. Not a text.
Slava, what do you think of adding "none" in the list of themes, and not blocking it when the shadow checkbox is not checked?
Maybe we should set the theme to "none" if shadows disabled but let users to change it. But I'm not sure.

There is one more potential improvement. Let's add an "Overlay theme" combo instead of the "overlay" checkbox.

Regarding popup button... There are a lot of properties for a button actually (see New Button wizard). We just tried not to overload the wizard. Maybe it's better to add a checkbox to have an option *not* to create a button at all. Then users can use New Button wizard and New Popup wizard to create fully customized button + popup. We have such an option for a back button in New Page wizard.
                
> jQuery Popup Wizard should let select Theme w/o Shadow selected
> ---------------------------------------------------------------
>
>                 Key: JBIDE-14751
>                 URL: https://issues.jboss.org/browse/JBIDE-14751
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: jsp/jsf/xml/html source editing
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Denis Golovin
>            Priority: Optional
>         Attachments: popup-no-shadow.png
>
>
> Theme should be available for selection even for popups without shadow or popup window look lust like flying text.
> !popup-no-shadow.png!
> For example code below 
> {code}
> <a href="#popup-1" data-role="button" data-inline="true" data-rel="popup">Popup</a>
> <div data-role="popup" id="popup-1" data-theme="a" data-shadow="false" class="ui-content">
>    <p>This is a popup</p>
> </div>
> {code}
> works just fine in browsersim

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list