[jbosstools-issues] [JBoss JIRA] (JBIDE-14919) drop PreferencePage and use PreferenceUtil to show SSH preferences

[Andre Dietisheim (JIRA)]

Andre Dietisheim created JBIDE-14919:
----------------------------------------

             Summary: drop PreferencePage and use PreferenceUtil to show SSH preferences
                 Key: JBIDE-14919
                 URL: https://issues.jboss.org/browse/JBIDE-14919
             Project: Tools (JBoss Tools)
          Issue Type: Enhancement
          Components: openshift
    Affects Versions: 4.1.0.Beta2
            Reporter: Andre Dietisheim
            Assignee: Andre Dietisheim
             Fix For: 4.1.0.CR1


in the Git clonging settings page of the OpenShift wizard, we offer a link to the SSH preferences. Clicking this link allows one to get to the SSH preferences and add some private key. When showing the preferences dialog we use legacy code:

{code:title=GitCloningSettingsWizardPage#onSshPrefs}
SshPrivateKeysPreferences.openPreferencesPage(getShell());
{code}

{code:title=SshPrivateKeysPreferences#openPreferencesPage}
public static void openPreferencesPage(Shell shell) {
	PreferenceDialog dialog = PreferencesUtil.createPreferenceDialogOn(
			shell, SSH_PREFERENCE_PAGE_ID, null, null);
	dialog.open();
}
{code}

This way of showing the Eclipse preferences is outdated, one should do

{code}
final PreferenceDialog dialog = PreferencesUtil.createPreferenceDialogOn(
	jreButton.getShell(),
	JREsPreferencePage.ID, 
	new String[] {}, 
	null);
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira