[jbosstools-issues] [JBoss JIRA] (JBIDE-14920) CordovaSim: need to replace global BsPopup variable with more elegant emulatorBridge.window() structure

Ilya Buziuk (JIRA) jira-events at lists.jboss.org
Tue Jun 18 10:23:21 EDT 2013


     [ https://issues.jboss.org/browse/JBIDE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Buziuk updated JBIDE-14920:
--------------------------------

    Description: 
While making PR for Ripple team (https://issues.apache.org/jira/browse/RIPPLE-26), a really elegant way of accessing child window/frame was found. 
Now we use global variable 'bsPopup' for accesing BrowserSim, which is not really neat solution: 
 - Implementation is tightly coupled with BrowserSim;
 - Problems with merging original ripple source code;
 - Have no possibility of patch sending to the ripple team;

There is a need in replacement all global bsPopup usage to 
{code}
  var emulatorBridge = ripple('emulatorBridge');
   .
   .
   .
   emulatorBridge.window();
{code}

  was:
While making PR for Ripple team (https://issues.apache.org/jira/browse/RIPPLE-26), a really elegant way of accessing child window/frame was found. 
Now we use global variable 'bsPopup' for accesing BrowserSim, which is not really neat solution: 
 1. Implementation is tightly coupled with BrowserSim;
 2. Problems with merging original ripple source code;
 3. Have no possibility of patch sending to the ripple team;

There is a need in replacement all global bsPopup usage to 
{code}
  var emulatorBridge = ripple('emulatorBridge');
   .
   .
   .
   emulatorBridge.window();
{code}


    
> CordovaSim: need to replace global BsPopup variable with more elegant emulatorBridge.window() structure
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-14920
>                 URL: https://issues.jboss.org/browse/JBIDE-14920
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: browsersim
>            Reporter: Ilya Buziuk
>            Assignee: Ilya Buziuk
>             Fix For: 4.1.0.CR1
>
>
> While making PR for Ripple team (https://issues.apache.org/jira/browse/RIPPLE-26), a really elegant way of accessing child window/frame was found. 
> Now we use global variable 'bsPopup' for accesing BrowserSim, which is not really neat solution: 
>  - Implementation is tightly coupled with BrowserSim;
>  - Problems with merging original ripple source code;
>  - Have no possibility of patch sending to the ripple team;
> There is a need in replacement all global bsPopup usage to 
> {code}
>   var emulatorBridge = ripple('emulatorBridge');
>    .
>    .
>    .
>    emulatorBridge.window();
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list