[jbosstools-issues] [JBoss JIRA] (JBIDE-14735) Improve text formatting when dropping widgets from Palette view

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783891#comment-12783891 ] 

Victor Rubezhny commented on JBIDE-14735:
-----------------------------------------

{quote}This is not correct. We should not format the text if we insert an one-line snippet into a not-empty line.{quote}

Look more detailed at the Button template: it is not a one-line snippet. It's two-line snippet - it has a new-line character at the end.

When inserted, the 'reformat' attribute is set to "yes", so I'm always adding a new line before the snippet text if it's not inserted into a new line.
If I'm wrong in doing this and will not do so, the result of insertion into the following text:
{code}
<td></td>
{code}
 will look like the following:
{code}
<td><a href="" id="button-2" data-role="button">Link button</a>
</td>
{code}
                
> Improve text formatting when dropping widgets from Palette view
> ---------------------------------------------------------------
>
>                 Key: JBIDE-14735
>                 URL: https://issues.jboss.org/browse/JBIDE-14735
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: jsp/jsf/xml/html source editing
>            Reporter: Alexey Kazakov
>            Assignee: Victor Rubezhny
>              Labels: new_and_noteworthy
>             Fix For: 4.2.x
>
>
> 1. Suppose we have the following code:
> {code}
> <div data-role="page" id="page-1">
>   <div data-role="content">|
>   </div>
> </div>
> {code}
> | marks the cursor position.
> 2. Press Enter right after <div data-role="content">:
> {code}
> <div data-role="page" id="page-1">
>   <div data-role="content">
>   |
>   </div>
> </div>
> {code}
> 3. Then click on *button* widget in jQuery Mobile Palette. Click on OK.
> The following code is generated:
> {code}
> <div data-role="page" id="page-1">
>   <div data-role="content">
>   <a href="" id="button-1" data-role="button">Link button</a>
>   
>   </div>
> </div>
> {code}
> But it should be
> {code}
> <div data-role="page" id="page-1">
>   <div data-role="content">
>     <a href="" id="button-1" data-role="button">Link button</a>
>   
>   </div>
> </div>
> {code}
> instead.
> Also we probably should use the preferences/settings of the editor to insert space symbols (N spaces/tab) instead of hardcoded "  ".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira