[jbosstools-issues] [JBoss JIRA] (JBDS-2389) cannot uninstall JBDS Product Feature - eclipse left in unusable state due to missing eclipse.ini directives

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784315#comment-12784315 ] 

Max Rydahl Andersen commented on JBDS-2389:
-------------------------------------------

Nick - do I read this right that the usecase is that users does this:

A) installs BYOE (as allowed/supported)

B) installs product branding features (uncategorized and unsupported feature)
     which adds and assumes it is jbds product and thus messes with eclipse.ini 

C) uninstalls product branding - which after uninstall goes bad.

if that is the case then this is not a supported thing so i'm not so fuzzed about it but the right fix then seem to be not to allow installing the branding feature or at least not do eclipse.ini mutations unless the product is actually jbds ?
                
> cannot uninstall JBDS Product Feature - eclipse left in unusable state due to missing eclipse.ini directives
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: JBDS-2389
>                 URL: https://issues.jboss.org/browse/JBDS-2389
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: installer, updatesite
>    Affects Versions: 6.0.0.CR1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 7.0.0.CR1
>
>
> Steps to repro:
> Unpack bare Juno JEE. 
> Install JBDS BYOE feature ("Core Features"). Restart
> Install JBDS Branded Product Feature. Restart. 
> Uninstall JBDS Branded Product Feature (or revert configuration to previous). Restart. Eclipse is now broken:
> {code}
> java.lang.RuntimeException: Application "" could not be found in the registry.
> {code}
> Addtional info:
> {quote}
> Bare Juno JEE eclipse.ini:
> {code}
> $➔ cat eclipse/eclipse.ini 
> -startup
> plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
> --launcher.library
> plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
> -product
> org.eclipse.epp.package.jee.product
> --launcher.defaultAction
> openFile
> -showsplash
> org.eclipse.platform
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -vmargs
> -Dosgi.requiredJavaVersion=1.5
> -Dhelp.lucene.tokenizer=standard
> -XX:MaxPermSize=256m
> -Xms40m
> -Xmx512m
> {code}
> or, for Eclipse Platform Binary:
> {code}
> -startup
> plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
> --launcher.library
> plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
> -showsplash
> org.eclipse.platform
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -vmargs
> -Xms40m
> -Xmx384m
> {code}
> After installing JBDS BYOE:
> {code}
> $➔ cat eclipse/eclipse.ini 
> -startup
> plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
> --launcher.library
> plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
> -showsplash
> org.eclipse.platform
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -vmargs
> -Xms512m
> -Xmx1024m
> -Djboss.discovery.directory.url=https://devstudio.jboss.com/updates/6.0-staging/devstudio-directory.xml
> {code}
> After installing JBDS branded product, eclipse.ini becomes jbdevstudio.ini:
> {code}
> $➔ cat eclipse/jbdevstudio.ini 
> -startup
> plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
> --launcher.library
> plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -product
> com.jboss.jbds.product.product
> -showsplash
> platform:/base/plugins/com.jboss.jbds.product
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -vmargs
> -Djboss.discovery.directory.url=https://devstudio.jboss.com/updates/6.0-staging/devstudio-directory.xml
> -Xms512m
> -Xmx1024m
> -Dosgi.instance.area.default=@user.home/workspace
> {code}
> After UNINSTALLING JBDS branded product (to drop back to Eclipse + JBDS BYOE), can no longer start Eclipse. Here is the resulting eclipse.ini file:
> {code}
> $➔ cat eclipse/eclipse.ini 
> -startup
> plugins/org.eclipse.equinox.launcher_1.3.0.v20120522-1813.jar
> --launcher.library
> plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.200.v20120522-1813
> -product
> com.jboss.jbds.product.product
> -showsplash
> platform:/base/plugins/com.jboss.jbds.product
> --launcher.XXMaxPermSize
> 256m
> --launcher.defaultAction
> openFile
> -vmargs
> -Djboss.discovery.directory.url=https://devstudio.jboss.com/updates/6.0-staging/devstudio-directory.xml
> -Xms512m
> -Xmx1024m
> {code}
> {quote}
> So, I think we need an instructions.unconfigure in com.jboss.jbds.p2.inf to remove these lines
> {code}
> -product
> com.jboss.jbds.product.product
> -showsplash
> platform:/base/plugins/com.jboss.jbds.product
> {code}
> and replace them with the following when JBDS is uninstalled:
> {code}
> -application 
> org.eclipse.ui.ide.workbench
> -showsplash
> org.eclipse.platform
> {code}
> Also need to know what happens if there are two -product directives... can we just 
> add (and later remove, when uninstalling) our product to the list, or must we replace 
> any existing -product entries with ours?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira