[jbosstools-issues] [JBoss JIRA] (JBIDE-13659) OpenShift Server wizard is giving different name to server adapter

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785418#comment-12785418 ] 

Andre Dietisheim commented on JBIDE-13659:
------------------------------------------

I identified the flaw:

The server adapter utility class had a "flawed" API where it was not clear enough under what circumstances a new adapter was created and when it was updating an existing one. The method overloads were hiding this and bad workarounds were implemented so that naming and updating/creating adapters was non-deterministic at times. I cleaned this and things should now behave correctly. 

To make sure this issue is solved and no side-effects were introduced it is especially important to test adapter creation via server wizard and openshift wizard. Editing the adapter via editor should also get tested.
                
> OpenShift Server wizard is giving different name to server adapter
> ------------------------------------------------------------------
>
>                 Key: JBIDE-13659
>                 URL: https://issues.jboss.org/browse/JBIDE-13659
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Stefan Bunciak
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.0.CR1
>
>         Attachments: out.ogv, out2.ogv
>
>
> Trying to create server adapter for application *spring* and server wizard uses a different name for the server adapter (actually from different accout): see [^out.ogv]
> No entry in error log.
> quoted from JBIDE-13801 (duplicate issue)
> {quote}
> When you create a server adapter for an existing application, in case it's missing, the server name is made after the first app in the domain, not the selected app in the openshift explorer view.
> In my case, I had 2 applications: "html5" and "test", and I wanted to create a server adapter for the "test" one (using the "Create Server Adapter" command), but the name was "html5 on OpenShift"
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira