[jbosstools-issues] [JBoss JIRA] (JBIDE-13663) Add test that egitutils/openshift does not include untracked files in dirty check nor will commit these untracked files

Andre Dietisheim (JIRA) jira-events at lists.jboss.org
Thu Jun 27 11:16:22 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785776#comment-12785776 ] 

Andre Dietisheim commented on JBIDE-13663:
------------------------------------------

@Max: please comment:

So by 

{quote}
EXECUTE: Add a "xyz.log" file that is not to be committed.
{quote}

you mean a file that is not in the the index yet, right?

Furthermore I dont fully understand why you dont want to have any confirmation before pushing:

{quote}
ASSERT: no message about dirty changes, everything should be committed. Only message about push is missing.
{quote}

The local git repo is ahead of the remote by 1 commit (the file we changed and then committed). Thus the adapter should inform you about this and ask you if you want to push the local changes upstream like we're doing currently:

!push-local-commit.png!
                
> Add test that egitutils/openshift does not include untracked files in dirty check nor will commit these untracked files
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13663
>                 URL: https://issues.jboss.org/browse/JBIDE-13663
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Max Rydahl Andersen
>            Assignee: Andre Dietisheim
>             Fix For: 4.2.x
>
>         Attachments: push-local-commit.png
>
>
> usecase: 
> EXECUTE: Create openshift project
> EXECUTE: Make sure all is committed and Pushed.
> EXECUTE: Edit an existing committed file - commit it.
> EXECUTE: Add a "xyz.log" file that is not to be committed.
> EXECUTE: Publish to server.
> ASSERT: no message about dirty changes, everything should be committed. Only message about push is missing.
> EXECUTE: Wait for publish to finish.
> ASSERT: "xyz.log" should *not* be pushed nor committed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list