[jbosstools-issues] [JBoss JIRA] (JBIDE-13628) Only one JBoss Central Configurator is selected for display

Max Rydahl Andersen (JIRA) jira-events at lists.jboss.org
Wed Mar 6 05:40:56 EST 2013


    [ https://issues.jboss.org/browse/JBIDE-13628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758904#comment-12758904 ] 

Max Rydahl Andersen commented on JBIDE-13628:
---------------------------------------------

Snjezana - lets at least get it documented in the extension point that this is not intended to be extended/implemented by individual plugins.
Only one of these extensions points should be active at any given time.

Plus lets get a warning logged if we actually find more than one extension point registered.

                
> Only one JBoss Central Configurator is selected for display
> -----------------------------------------------------------
>
>                 Key: JBIDE-13628
>                 URL: https://issues.jboss.org/browse/JBIDE-13628
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: central
>            Reporter: Paul Richardson
>            Assignee: Max Rydahl Andersen
>            Priority: Minor
>             Fix For: 4.1.0.Alpha1
>
>
> I wanted to contribute Teiid Designer's 'new model project' wizard as a link in the 'Create Projects' section of JBoss Central. [link|http://www.phantomjinx.co.uk/stuff/jboss-central.png]
> However, I found that the list of project wizards is hard-coded in the default configurator [1]. Thus, the only way I can contribute this link is by extending the default configurator and using the configurators extension point[2] to load my configurator.
> This works correctly but if another project decides to do the same thing then their configurator 'could' be loaded instead of mine due to the following logic in [3]:
> {code:title=ProjectExamplesActivator.java|borderStyle=solid}
> // ... ~ Line 1163
> IExtension extension = extensions[0];
> IConfigurationElement[] configurationElements = extension.getConfigurationElements();
> for (int j = 0; j < configurationElements.length; j++) {
>   IConfigurationElement configurationElement = configurationElements[j];
>   if (CONFIGURATOR.equals(configurationElement.getName())) {
>     try {
>       configurator = (IJBossCentralConfigurator) configurationElement.createExecutableExtension("class");
>     } catch (CoreException e) {
>       ProjectExamplesActivator.log(e);
>       continue;
>     }
>     break;
>   }
> }
> // ...
> {code}
>  
> Thought an alternative configurator that aggregates all extension-pointed configurators and displays the content of each accordingly.
> Happy to provide a patch if required.
> [1] org.jboss.tools.project.examples.configurators.DefaultJBossCentralConfigurator
> [2] org.jboss.tools.project.examples.configurators
> [3] org.jboss.tools.project.examples.ProjectExamplesActivator.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list