[jbosstools-issues] [JBoss JIRA] (JBIDE-13733) Clean up JBossASHandler

[Rob Stryker (JIRA)]

Rob Stryker created JBIDE-13733:
-----------------------------------

             Summary: Clean up JBossASHandler
                 Key: JBIDE-13733
                 URL: https://issues.jboss.org/browse/JBIDE-13733
             Project: Tools (JBoss Tools)
          Issue Type: Task
          Components: JBossAS/Servers
    Affects Versions: 4.1.0.Alpha1
            Reporter: Rob Stryker
            Assignee: Rob Stryker
             Fix For: 4.1.0.Alpha2


JBossASHandler is a pretty messy class with many confusing parts to it. Several things need to be changed. 

1) Why are default names for server required in this class? Don't runtime type and server type already do this in getDefaults() when the working copy is created?

2) The code to check for nested runtimes is very messy and hard to understand. 

3) Why are ESB and Drools added separately? Shouldn't the check for all nested runtimes using all handlers be able to find this itself? It seems drools and esb have their own detectors. So why is this required here?

4) The drools runtime seems to be not added to any model at all. It seems to just be returned. Is this only cosmetic? What is the purpose here? The drools detector would be adding this to the drools model, but we do not add it to any model, so what is the purpose? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira