[jbosstools-issues] [JBoss JIRA] (JBIDE-13671) parent pom should use last-mod-timestamp from git for a plugin/feature instead of current timestamp when building

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759445#comment-12759445 ] 

Mickael Istria commented on JBIDE-13671:
----------------------------------------

> You mean if you got asserver-1.0.2-24234234234 and asserver-1.0.2-werwer it should assume they are the same ?

Yes, it would compare them and replace the new one with the one from baseline if they are the same. Of course, one could disable this behaviour.

> What would it use for "Same content" ?

Default p2 JarComparator looks at actual content: MANIFEST fields, class files and so on. https://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.repository.tools/src/org/eclipse/equinox/p2/internal/repository/comparator/JarComparator.java
We could think in making it able to do this comparison but ignore the qualifier.

                
> parent pom should use last-mod-timestamp from git for a plugin/feature instead of current timestamp when building
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13671
>                 URL: https://issues.jboss.org/browse/JBIDE-13671
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.1.x
>
>         Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
>        <plugin>
>           <groupId>org.eclipse.tycho</groupId>
>           <artifactId>tycho-packaging-plugin</artifactId>
>           <version>${tycho.version}</version>
>           <dependencies>
>             <dependency>
>               <groupId>org.eclipse.tycho.extras</groupId>
>               <artifactId>tycho-buildtimestamp-jgit</artifactId>
>               <version>${tycho-extras.version}</version>
>             </dependency>
>           </dependencies>
>           <configuration>
>             <strictBinIncludes>false</strictBinIncludes>
>             <format>'v'yyyyMMdd-HHmm</format>
>             <timestampProvider>jgit</timestampProvider>
>             <jgit.ignore>
>             </jgit.ignore>
>           </configuration>
>         </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira