[jbosstools-issues] [JBoss JIRA] (JBIDE-13671) parent pom should use last-mod-timestamp from git for a plugin/feature instead of current timestamp when building

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759810#comment-12759810 ] 

Nick Boldt commented on JBIDE-13671:
------------------------------------

[~mickael_istria] Good point. We'd have to implement an override in the JBDS root pom that would turn off jgit timestamp provider.

As to the question about correlated sentences, my proposal was to do *these 4 things together*:

a) profile for Jenkins needs to be updated to use "-CI" instead of "-B${BUILD_NUMBER}"
b) profile for Jenkins uses jgit timestamp provider
c) default profile omits the "-CI" and "-Bxxxx" suffix, as it does today
d) default profile uses the default timestamp provider, as it does today

I thought that was obvious from the PR, but I guess not.

https://github.com/jbosstools/jbosstools-build/pull/73

Perhaps instead of talking about how to code, we could just review PRs, and run some tests?

                
> parent pom should use last-mod-timestamp from git for a plugin/feature instead of current timestamp when building
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-13671
>                 URL: https://issues.jboss.org/browse/JBIDE-13671
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.1.x
>
>         Attachments: jbide13671-before-and-after.png
>
>
> This needs to be added to master parent pom:
> {code}
>        <plugin>
>           <groupId>org.eclipse.tycho</groupId>
>           <artifactId>tycho-packaging-plugin</artifactId>
>           <version>${tycho.version}</version>
>           <dependencies>
>             <dependency>
>               <groupId>org.eclipse.tycho.extras</groupId>
>               <artifactId>tycho-buildtimestamp-jgit</artifactId>
>               <version>${tycho-extras.version}</version>
>             </dependency>
>           </dependencies>
>           <configuration>
>             <strictBinIncludes>false</strictBinIncludes>
>             <format>'v'yyyyMMdd-HHmm</format>
>             <timestampProvider>jgit</timestampProvider>
>             <jgit.ignore>
>             </jgit.ignore>
>           </configuration>
>         </plugin>
> {code}
> Ref: http://pweclipse.blogspot.ch/2012_09_01_archive.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira