[jbosstools-issues] [JBoss JIRA] (JBIDE-13733) Clean up JBossASHandler

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760761#comment-12760761 ] 

Rob Stryker commented on JBIDE-13733:
-------------------------------------

Snjezana:

I've just run a test as follows:
  1) Disable AS handler
  2) Point to a soa-p installation
  3) Run the runtime search dialog

There are no results found. This means that the ESB Detector is *not* finding the esb runtime if pointed to an soa-p installation unless the AS Handler is enabled. 

This would seem like a bug in the ESB detector to me, and it seems that JBossASHandler returning an esb runtime itself is actually a workaround this bug. It is NOT a workaround that the locator stops searching after finding an AS server and no longer searches the nested paths. It is a workaround in that the esb detector will not even recognize esb runtimes nested inside a soa-p installation. 

I haven't had a chance to test drools yet, but I suspect it is a similar issue. 
                
> Clean up JBossASHandler
> -----------------------
>
>                 Key: JBIDE-13733
>                 URL: https://issues.jboss.org/browse/JBIDE-13733
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: JBossAS/Servers
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.1.0.Alpha2
>
>
> JBossASHandler is a pretty messy class with many confusing parts to it. Several things need to be changed. 
> 1) Why are default names for server required in this class? Don't runtime type and server type already do this in getDefaults() when the working copy is created?
> 2) The code to check for nested runtimes is very messy and hard to understand. 
> 3) Why are ESB and Drools added separately? Shouldn't the check for all nested runtimes using all handlers be able to find this itself? It seems drools and esb have their own detectors. So why is this required here?
> 4) The drools runtime seems to be not added to any model at all. It seems to just be returned. Is this only cosmetic? What is the purpose here? The drools detector would be adding this to the drools model, but we do not add it to any model, so what is the purpose? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira